External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-20 02:30:08 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

lint: DeckValidator

Browse source
This commit is contained in:
xenohedron 2024-06-19 18:26:07 -04:00
parent e851e04906
commit 9f917472fc
1 changed files with 23 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Mage/src/main/java/mage/cards/decks/DeckValidator.java
View file

@ -11,7 +11,7 @@ import java.util.stream.Collectors;
*/
public abstract class DeckValidator implements Serializable {
public static final HashSet<String> MAIN_BASIC_LAND_NAMES = new HashSet<>(Arrays.asList(
public static final Set<String> MAIN_BASIC_LAND_NAMES = new HashSet<>(Arrays.asList(
"Plains",
"Island",
"Swamp",
@ -19,7 +19,7 @@ public abstract class DeckValidator implements Serializable {
"Forest"
));
public static final HashSet<String> ADDITIONAL_BASIC_LAND_NAMES = new HashSet<>(Arrays.asList(
public static final Set<String> ADDITIONAL_BASIC_LAND_NAMES = new HashSet<>(Arrays.asList(
"Wastes",
"Snow-Covered Plains",
"Snow-Covered Island",
@ -29,9 +29,9 @@ public abstract class DeckValidator implements Serializable {
"Snow-Covered Wastes"
));
public static final HashSet<String> ALL_BASIC_LAND_NAMES = new HashSet<>();
public static final Set<String> ALL_BASIC_LAND_NAMES = new HashSet<>();
{
static {
ALL_BASIC_LAND_NAMES.addAll(MAIN_BASIC_LAND_NAMES);
ALL_BASIC_LAND_NAMES.addAll(ADDITIONAL_BASIC_LAND_NAMES);
}
@ -57,7 +57,7 @@ public abstract class DeckValidator implements Serializable {
protected String shortName;
protected List<DeckValidatorError> errorsList = new ArrayList<>();
public DeckValidator(String name, String shortName) {
protected DeckValidator(String name, String shortName) {
setName(name, shortName);
}
@ -94,15 +94,11 @@ public abstract class DeckValidator implements Serializable {
/**
* Get errors list sorted by error type and texts
*
* @return
*/
public List<DeckValidatorError> getErrorsListSorted(int maxErrors) {
List<DeckValidatorError> list = new ArrayList<>(this.getErrorsList());
list.sort(new Comparator<DeckValidatorError>() {
@Override
public int compare(DeckValidatorError e1, DeckValidatorError e2) {
list.sort((e1, e2) -> {
int res = 0;
// sort by error type
@ -121,7 +117,6 @@ public abstract class DeckValidator implements Serializable {
}
return res;
}
});
if (list.size() <= maxErrors) {
@ -163,7 +158,7 @@ public abstract class DeckValidator implements Serializable {
}
public boolean isPartlyValid() {
return errorsList.size() == 0 || !errorsList.stream().anyMatch(e -> !e.getErrorType().isPartlyLegal());
return errorsList.isEmpty() || errorsList.stream().allMatch(e -> e.getErrorType().isPartlyLegal());
}
protected void countCards(Map<String, Integer> counts, Collection<Card> cards) {
@ -184,7 +179,7 @@ public abstract class DeckValidator implements Serializable {
public abstract int getSideboardMinSize();
protected static final int getMaxCopies(String name, int defaultAmount) {
protected static int getMaxCopies(String name, int defaultAmount) {
return maxCopiesMap.getOrDefault(name, defaultAmount);
}
}