mirror of
https://github.com/magefree/mage.git
synced 2025-12-26 21:42:07 -08:00
Changes related to Cascade ability (#7583):
* Cascade: added correct spell ability choose for forced cast of mdf and adventure cards (can contains one or both sides); * Cascade: added tests from latest oracle changes; * AI: improved spell ability choose for forced cast (example: cast target card without mana cost); * GUI: improved spell ability choose for forced cast (now you can see only castable spells to choose); * Other: fixed wrong PlayFromNotOwnHandZone in some cards, fixed NPE;
This commit is contained in:
Oleg Agafonov
parent
0c65a6fb7e
commit
91f4d78992
12 changed files with 178 additions and 43 deletions
|
|
@ -1,6 +1,7 @@
|
|||
package mage.abilities.keyword;
|
||||
|
||||
import mage.ApprovingObject;
|
||||
import mage.MageObject;
|
||||
import mage.abilities.Ability;
|
||||
import mage.abilities.TriggeredAbilityImpl;
|
||||
import mage.abilities.effects.OneShotEffect;
|
||||
|
|
@ -14,6 +15,10 @@ import mage.game.stack.Spell;
|
|||
import mage.players.Player;
|
||||
import mage.target.common.TargetCardInExile;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
import java.util.stream.Collectors;
|
||||
|
||||
/**
|
||||
* @author BetaSteward_at_googlemail.com
|
||||
*/
|
||||
|
|
@ -91,6 +96,8 @@ class CascadeEffect extends OneShotEffect {
|
|||
if (sourceCard == null) {
|
||||
return false;
|
||||
}
|
||||
|
||||
// exile cards from the top of your library until you exile a nonland card whose converted mana cost is less than this spell's converted mana cost
|
||||
Cards cardsToExile = new CardsImpl();
|
||||
int sourceCost = sourceCard.getConvertedManaCost();
|
||||
Card cardToCast = null;
|
||||
|
|
@ -101,60 +108,65 @@ class CascadeEffect extends OneShotEffect {
|
|||
break;
|
||||
}
|
||||
}
|
||||
|
||||
controller.moveCards(cardsToExile, Zone.EXILED, source, game);
|
||||
controller.getLibrary().reset(); // set back empty draw state if that caused an empty draw
|
||||
|
||||
// additional replacement effect: As you cascade, you may put a land card from among the exiled cards onto the battlefield tapped
|
||||
GameEvent event = GameEvent.getEvent(GameEvent.EventType.CASCADE_LAND, source.getSourceId(), source, source.getControllerId(), 0);
|
||||
game.replaceEvent(event);
|
||||
if (event.getAmount() > 0) {
|
||||
TargetCardInExile target = new TargetCardInExile(
|
||||
0, event.getAmount(), StaticFilters.FILTER_CARD_LAND, null, true
|
||||
);
|
||||
TargetCardInExile target = new TargetCardInExile(0, event.getAmount(), StaticFilters.FILTER_CARD_LAND, null, true);
|
||||
target.withChooseHint("land to put onto battlefield tapped");
|
||||
controller.choose(Outcome.PutCardInPlay, cardsToExile, target, game);
|
||||
controller.moveCards(
|
||||
new CardsImpl(target.getTargets()).getCards(game), Zone.BATTLEFIELD,
|
||||
source, game, true, false, false, null
|
||||
);
|
||||
}
|
||||
if (cardToCast != null && controller.chooseUse(
|
||||
outcome, "Use cascade effect on " + cardToCast.getLogName() + '?', source, game
|
||||
)) {
|
||||
// Check to see if player is allowed to cast the back half
|
||||
// Front half is already checked by exile effect
|
||||
if (cardToCast instanceof ModalDoubleFacesCard) {
|
||||
ModalDoubleFacesCardHalf leftHalf = ((ModalDoubleFacesCard) cardToCast).getLeftHalfCard();
|
||||
ModalDoubleFacesCardHalf rightHalf = ((ModalDoubleFacesCard) cardToCast).getRightHalfCard();
|
||||
if (rightHalf.getConvertedManaCost() < sourceCost) {
|
||||
castForFree(cardToCast, source, game, controller);
|
||||
} else {
|
||||
castForFree(leftHalf, source, game, controller);
|
||||
}
|
||||
|
||||
// You may cast that spell without paying its mana cost if its converted mana cost is less than this spell's converted mana cost.
|
||||
List<Card> partsToCast = new ArrayList<>();
|
||||
if (cardToCast != null) {
|
||||
if (cardToCast instanceof SplitCard) {
|
||||
partsToCast.add(((SplitCard) cardToCast).getLeftHalfCard());
|
||||
partsToCast.add(((SplitCard) cardToCast).getRightHalfCard());
|
||||
partsToCast.add(cardToCast);
|
||||
} else if (cardToCast instanceof AdventureCard) {
|
||||
Card adventureSpell = ((AdventureCard) cardToCast).getSpellCard();
|
||||
if (adventureSpell.getConvertedManaCost() < sourceCost) {
|
||||
castForFree(cardToCast, source, game, controller);
|
||||
} else {
|
||||
game.getState().setValue("PlayFromNotOwnHandZone" + cardToCast.getId(), Boolean.TRUE);
|
||||
controller.cast(cardToCast.getSpellAbility(), game, true, new ApprovingObject(source, game));
|
||||
game.getState().setValue("PlayFromNotOwnHandZone" + cardToCast.getId(), null);
|
||||
}
|
||||
partsToCast.add(((AdventureCard) cardToCast).getSpellCard());
|
||||
partsToCast.add(cardToCast);
|
||||
} else if (cardToCast instanceof ModalDoubleFacesCard) {
|
||||
partsToCast.add(((ModalDoubleFacesCard) cardToCast).getLeftHalfCard());
|
||||
partsToCast.add(((ModalDoubleFacesCard) cardToCast).getRightHalfCard());
|
||||
} else {
|
||||
castForFree(cardToCast, source, game, controller);
|
||||
partsToCast.add(cardToCast);
|
||||
}
|
||||
// remove too big cmc
|
||||
partsToCast.removeIf(card -> card.getConvertedManaCost() >= sourceCost);
|
||||
// remove non spells
|
||||
partsToCast.removeIf(card -> card.getSpellAbility() == null);
|
||||
}
|
||||
|
||||
String partsInfo = partsToCast.stream()
|
||||
.map(MageObject::getIdName)
|
||||
.collect(Collectors.joining(" or "));
|
||||
if (cardToCast != null
|
||||
&& partsToCast.size() > 0
|
||||
&& controller.chooseUse(outcome, "Cast spell without paying its mana cost (" + partsInfo + ")?", source, game)) {
|
||||
try {
|
||||
// enable free cast for all compatible parts
|
||||
partsToCast.forEach(card -> game.getState().setValue("PlayFromNotOwnHandZone" + card.getId(), Boolean.TRUE));
|
||||
controller.cast(controller.chooseAbilityForCast(cardToCast, game, true),
|
||||
game, true, new ApprovingObject(source, game));
|
||||
} finally {
|
||||
partsToCast.forEach(card -> game.getState().setValue("PlayFromNotOwnHandZone" + card.getId(), null));
|
||||
}
|
||||
}
|
||||
// Move the remaining cards to the buttom of the library in a random order
|
||||
|
||||
// Then put all cards exiled this way that weren't cast on the bottom of your library in a random order.
|
||||
cardsToExile.removeIf(uuid -> game.getState().getZone(uuid) != Zone.EXILED);
|
||||
return controller.putCardsOnBottomOfLibrary(cardsToExile, game, source, false);
|
||||
}
|
||||
|
||||
private void castForFree(Card cardToCast, Ability source, Game game, Player controller) {
|
||||
game.getState().setValue("PlayFromNotOwnHandZone" + cardToCast.getId(), Boolean.TRUE);
|
||||
controller.cast(controller.chooseAbilityForCast(cardToCast, game, true),
|
||||
game, true, new ApprovingObject(source, game));
|
||||
game.getState().setValue("PlayFromNotOwnHandZone" + cardToCast.getId(), null);
|
||||
}
|
||||
|
||||
@Override
|
||||
public CascadeEffect copy() {
|
||||
return new CascadeEffect(this);
|
||||
|
|
|
|||
|
|
@ -365,6 +365,20 @@ public interface Player extends MageItem, Copyable<Player> {
|
|||
|
||||
boolean cast(SpellAbility ability, Game game, boolean noMana, ApprovingObject approvingObject);
|
||||
|
||||
/**
|
||||
* Force player to choose spell ability to cast. Use it in effects while casting cards.
|
||||
*
|
||||
* Commands order in all use cases:
|
||||
* - PlayFromNotOwnHandZone - true
|
||||
* - chooseAbilityForCast
|
||||
* - cast
|
||||
* - PlayFromNotOwnHandZone - false
|
||||
*
|
||||
* @param card
|
||||
* @param game
|
||||
* @param noMana
|
||||
* @return
|
||||
*/
|
||||
SpellAbility chooseAbilityForCast(Card card, Game game, boolean noMana);
|
||||
|
||||
boolean putInHand(Card card, Game game);
|
||||
|
|
|
|||
|
|
@ -1519,14 +1519,26 @@ public abstract class PlayerImpl implements Player, Serializable {
|
|||
return false;
|
||||
}
|
||||
|
||||
/**
|
||||
* Return spells for possible cast
|
||||
* Uses in GUI to show only playable spells for choosing from the card
|
||||
* (example: effect allow to cast card and player must choose the spell ability)
|
||||
*
|
||||
* @param playerId
|
||||
* @param object
|
||||
* @param zone
|
||||
* @param game
|
||||
* @return
|
||||
*/
|
||||
public static LinkedHashMap<UUID, ActivatedAbility> getSpellAbilities(UUID playerId, MageObject object, Zone zone, Game game) {
|
||||
// it uses simple check from spellCanBeActivatedRegularlyNow
|
||||
// reason: no approved info here (e.g. forced to choose spell ability from cast card)
|
||||
LinkedHashMap<UUID, ActivatedAbility> useable = new LinkedHashMap<>();
|
||||
for (Ability ability : object.getAbilities()) {
|
||||
if (ability instanceof SpellAbility) {
|
||||
switch (((SpellAbility) ability).getSpellAbilityType()) {
|
||||
case BASE_ALTERNATE:
|
||||
ActivationStatus as = ((SpellAbility) ability).canActivate(playerId, game);
|
||||
if (as.canActivate()) {
|
||||
if (((SpellAbility) ability).spellCanBeActivatedRegularlyNow(playerId, game)) {
|
||||
useable.put(ability.getId(), (SpellAbility) ability); // example: Chandra, Torch of Defiance +1 loyal ability
|
||||
}
|
||||
return useable;
|
||||
|
|
@ -1560,7 +1572,9 @@ public abstract class PlayerImpl implements Player, Serializable {
|
|||
}
|
||||
return useable;
|
||||
default:
|
||||
useable.put(ability.getId(), (SpellAbility) ability);
|
||||
if (((SpellAbility) ability).spellCanBeActivatedRegularlyNow(playerId, game)) {
|
||||
useable.put(ability.getId(), (SpellAbility) ability);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
@ -2713,7 +2727,9 @@ public abstract class PlayerImpl implements Player, Serializable {
|
|||
|
||||
// casting selected card
|
||||
// TODO: fix costs (why is Panglacial Wurm automatically accepting payment?)
|
||||
game.getState().setValue("PlayFromNotOwnHandZone" + card.getId(), Boolean.TRUE);
|
||||
targetPlayer.cast(targetPlayer.chooseAbilityForCast(card, game, false), game, false, null);
|
||||
game.getState().setValue("PlayFromNotOwnHandZone" + card.getId(), null);
|
||||
castableCards.remove(card.getId());
|
||||
casted = true;
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue