External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-25 13:02:06 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleanup: PreventDamageAndRemoveCountersEffect (#10321)

Browse source 
* Add tests (two passing, one failing due to incorrect implementation)

* Cleanup PreventDamageAndRemoveCountersEffect; fix Protean Hydra
This commit is contained in:
xenohedron 2023-06-02 11:29:51 +03:00 • committed by GitHub
parent 0df610fbe7
commit 913d5dfee8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 111 additions and 175 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Mage/src/main/java/mage/abilities/effects/PreventDamageAndRemoveCountersEffect.java
View file

@ -12,17 +12,23 @@ import mage.game.permanent.Permanent;
*/
public class PreventDamageAndRemoveCountersEffect extends PreventionEffectImpl {
private final boolean thatMany;
private final boolean whileHasCounter;
public PreventDamageAndRemoveCountersEffect(boolean thatMany) {
public PreventDamageAndRemoveCountersEffect(boolean thatMany, boolean whileHasCounter, boolean textFromIt) {
super(Duration.WhileOnBattlefield, Integer.MAX_VALUE, false, false);
this.thatMany = thatMany;
staticText = "If damage would be dealt to {this} while it has a +1/+1 counter on it, " +
"prevent that damage and remove " + (thatMany ? "that many +1/+1 counters" : "a +1/+1 counter") + " from it";
this.whileHasCounter = whileHasCounter;
staticText = "If damage would be dealt to {this}" +
(whileHasCounter ? " while it has a +1/+1 counter on it" : "") +
", prevent that damage and remove " +
(thatMany ? "that many +1/+1 counters" : "a +1/+1 counter") +
" from " + (textFromIt ? "it" : "{this}");
}
private PreventDamageAndRemoveCountersEffect(final PreventDamageAndRemoveCountersEffect effect) {
protected PreventDamageAndRemoveCountersEffect(final PreventDamageAndRemoveCountersEffect effect) {
super(effect);
this.thatMany = effect.thatMany;
this.whileHasCounter = effect.whileHasCounter;
}
@Override
@ -56,6 +62,6 @@ public class PreventDamageAndRemoveCountersEffect extends PreventionEffectImpl {
return super.applies(event, source, game)
&& permanent != null
&& event.getTargetId().equals(source.getSourceId())
&& permanent.getCounters(game).containsKey(CounterType.P1P1);
&& (!whileHasCounter || permanent.getCounters(game).containsKey(CounterType.P1P1));
}
}