From 8e3b610a0c0cc1284d9b10b712d21856e36dc30a Mon Sep 17 00:00:00 2001 From: Oleg Agafonov Date: Tue, 9 Jan 2018 19:27:25 +0400 Subject: [PATCH] Tests: fixed performance problem (x20 speed up, no need to call full garbage collector manually) --- Mage.Client/src/main/java/mage/client/cards/CardGrid.java | 1 - .../java/org/mage/plugins/card/images/DownloadPictures.java | 2 +- .../mage/test/serverside/base/impl/CardTestPlayerAPIImpl.java | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Mage.Client/src/main/java/mage/client/cards/CardGrid.java b/Mage.Client/src/main/java/mage/client/cards/CardGrid.java index fe918f797d2..8f2f2fa9e01 100644 --- a/Mage.Client/src/main/java/mage/client/cards/CardGrid.java +++ b/Mage.Client/src/main/java/mage/client/cards/CardGrid.java @@ -122,7 +122,6 @@ public class CardGrid extends javax.swing.JLayeredPane implements MouseListener, addCard(card, bigCard, gameId, drawImage); } } - // System.gc(); drawCards(sortSetting); this.setVisible(true); } diff --git a/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPictures.java b/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPictures.java index 08e350a2137..26ce8adc734 100644 --- a/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPictures.java +++ b/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPictures.java @@ -648,7 +648,7 @@ public class DownloadPictures extends DefaultBoundedRangeModel implements Runnab logger.fatal("Couldn't unmount zip files", e); JOptionPane.showMessageDialog(null, "Couldn't unmount zip files", "Error", JOptionPane.ERROR_MESSAGE); } finally { - System.gc(); + // } closeButton.setText("Close"); updateCardsToDownload(jComboBoxSet.getSelectedItem().toString()); diff --git a/Mage.Tests/src/test/java/org/mage/test/serverside/base/impl/CardTestPlayerAPIImpl.java b/Mage.Tests/src/test/java/org/mage/test/serverside/base/impl/CardTestPlayerAPIImpl.java index 537d8b18422..ba66640d759 100644 --- a/Mage.Tests/src/test/java/org/mage/test/serverside/base/impl/CardTestPlayerAPIImpl.java +++ b/Mage.Tests/src/test/java/org/mage/test/serverside/base/impl/CardTestPlayerAPIImpl.java @@ -116,7 +116,6 @@ public abstract class CardTestPlayerAPIImpl extends MageTestPlayerBase implement if (currentGame != null) { logger.debug("Resetting previous game and creating new one!"); currentGame = null; - System.gc(); } currentGame = createNewGameAndPlayers();