From 8109532adf3cd334d80e261a1aa131b255725714 Mon Sep 17 00:00:00 2001 From: Neil Gentleman Date: Sat, 15 Oct 2016 22:22:13 -0700 Subject: [PATCH] ThreadLocalStringBuilder is slower here by about 30%, as measured by JMH avoiding garbage is more important when the string is more than 5 characters long --- Mage/src/main/java/mage/ObjectColor.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Mage/src/main/java/mage/ObjectColor.java b/Mage/src/main/java/mage/ObjectColor.java index 4c4e1eb01fe..cbe2870216a 100644 --- a/Mage/src/main/java/mage/ObjectColor.java +++ b/Mage/src/main/java/mage/ObjectColor.java @@ -31,12 +31,9 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; import mage.util.Copyable; -import mage.util.ThreadLocalStringBuilder; public class ObjectColor implements Serializable, Copyable, Comparable { - private static final ThreadLocalStringBuilder threadLocalBuilder = new ThreadLocalStringBuilder(10); - public static final ObjectColor WHITE = new ObjectColor("W"); public static final ObjectColor BLUE = new ObjectColor("U"); public static final ObjectColor BLACK = new ObjectColor("B"); @@ -231,7 +228,7 @@ public class ObjectColor implements Serializable, Copyable, Compara @Override public String toString() { - StringBuilder sb = threadLocalBuilder.get(); + StringBuilder sb = new StringBuilder(5); if (white) { sb.append("W"); }