External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-27 22:12:03 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

* Fixed a bug that if all targets (if targets were set) of a spell with an up to target definition (e.g. Adverse Conditions) became illegal the spell did not fizzle as it should.

Browse source
This commit is contained in:
LevelX2 2015-09-30 00:53:33 +02:00
parent 0d755b3c89
commit 8044940a97
5 changed files with 153 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Mage/src/mage/target/TargetImpl.java
View file

@ -345,7 +345,6 @@ public abstract class TargetImpl implements Target {
public boolean isLegal(Ability source, Game game) {
//20101001 - 608.2b
Set<UUID> illegalTargets = new HashSet<>();
// int replacedTargets = 0;
for (UUID targetId : targets.keySet()) {
Card card = game.getCard(targetId);
if (card != null) {
@ -367,12 +366,17 @@ public abstract class TargetImpl implements Target {
for (UUID targetId : illegalTargets) {
targets.remove(targetId);
}
// if (replacedTargets > 0 && replacedTargets == targets.size()) {
// return false;
// }
if (getNumberOfTargets() == 0 && targets.isEmpty()) {
return true;
if (targets.isEmpty()) {
// If all targets that were set before are illegal now, the target is no longer legal
if (!illegalTargets.isEmpty()) {
return false;
}
// if no targets have to be set and no targets are set, that's legal
if (getNumberOfTargets() == 0) {
return true;
}
}
return targets.size() > 0;
}