From 7d34484362e44a7680979e246d9f22908ee04266 Mon Sep 17 00:00:00 2001 From: Susucre <34709007+Susucre@users.noreply.github.com> Date: Sun, 27 Aug 2023 23:58:51 +0200 Subject: [PATCH] verify test: fix false positives from mana ability adjustments (#11047) --- .../java/mage/verify/VerifyCardDataTest.java | 33 ++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java b/Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java index 8b3c55a27a1..5be3c4ed4d4 100644 --- a/Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java +++ b/Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java @@ -2373,7 +2373,15 @@ public class VerifyCardDataTest { private String splitManaAbilities(String refText) { for (String s : refText.split("[\\$\\\n]")) { - if (!Pattern.matches(".*: Add [^\\.]* or.*\\..*", s)) { + if (!Pattern.matches("[^\"']*: Add [^\\.]* or.*\\..*", s)) { + continue; + } + // Loyalty Abilities + if (s.startsWith("0") || s.startsWith("+") || s.startsWith("-")) { + continue; + } + // Leafkin Avenger + if (s.contains("} for")) { continue; } @@ -2433,6 +2441,29 @@ public class VerifyCardDataTest { "{T}: Add {B}. Activate only if you control a swamp.\n{T}: Add {U}. Activate only if you control a swamp.", splitManaAbilities("{T}: Add {B} or {U}. Activate only if you control a swamp.") ); + + + // Not splitting those: + Assert.assertEquals( + "{T}: Each player creates a colorless artifact token named Banana with \"{T}, Sacrifice this artifact: Add {R} or {G}. You gain 2 life.\"", + splitManaAbilities("{T}: Each player creates a colorless artifact token named Banana with \"{T}, Sacrifice this artifact: Add {R} or {G}. You gain 2 life.\"") + ); + Assert.assertEquals( + "+1: Add {R} or {G}. Creature spells you cast this turn can't be countered.", + splitManaAbilities("+1: Add {R} or {G}. Creature spells you cast this turn can't be countered.") + ); + Assert.assertEquals( + "0: Add {R} or {G}. Creature spells you cast this turn can't be countered.", + splitManaAbilities("0: Add {R} or {G}. Creature spells you cast this turn can't be countered.") + ); + Assert.assertEquals( + "-1: Add {R} or {G}. Creature spells you cast this turn can't be countered.", + splitManaAbilities("-1: Add {R} or {G}. Creature spells you cast this turn can't be countered.") + ); + Assert.assertEquals( + "{T}: Add {G} for each creature with power 4 or greater you control.", + splitManaAbilities("{T}: Add {G} for each creature with power 4 or greater you control.") + ); } private void checkTypes(Card card, MtgJsonCard ref) {