External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-22 19:41:59 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fumble effect not working per #5155 feedback

Browse source 
Bug on Fumble: Hello,I casted "Fumble" (Battlebond) targeting a Serra Ascendant, the spell resolved but the ascendant stayed on the battlefield. (reported by Endymion / 2018-07-20 15:28:06.142).
This commit is contained in:
Michael Simons 2018-08-03 00:21:16 -04:00 • committed by GitHub
parent 097569148e
commit 79e94eef8e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

36
Mage.Sets/src/mage/cards/f/Fumble.java
View file

@ -66,7 +66,7 @@ class FumbleEffect extends OneShotEffect {
@Override @Override
public boolean apply(Game game, Ability source) { public boolean apply(Game game, Ability source) {
Permanent permanent = game.getPermanent(source.getSourceId()); Permanent permanent = game.getPermanent(source.getTargets().getFirstTarget());
Player player = game.getPlayer(source.getControllerId()); Player player = game.getPlayer(source.getControllerId());
if (player == null || permanent == null) { if (player == null || permanent == null) {
return false; return false;
@ -75,24 +75,30 @@ class FumbleEffect extends OneShotEffect {
for (UUID permId : permanent.getAttachments()) { for (UUID permId : permanent.getAttachments()) {
Permanent attachment = game.getPermanent(permId); Permanent attachment = game.getPermanent(permId);
if (attachment != null) { if (attachment != null) {
attachments.add(permanent); if (attachment.hasSubtype(SubType.AURA, game) || attachment.hasSubtype(SubType.EQUIPMENT, game)) {
attachments.add(attachment);
}
} }
} }
new ReturnToHandTargetEffect().apply(game, source); new ReturnToHandTargetEffect().apply(game, source);
Target target = new TargetCreaturePermanent(1, 1, StaticFilters.FILTER_PERMANENT_CREATURE, true);
Permanent newCreature = null; if (!attachments.isEmpty()) {
if (player.choose(Outcome.BoostCreature, target, source.getSourceId(), game)) { Target target = new TargetCreaturePermanent(1, 1, StaticFilters.FILTER_PERMANENT_CREATURE, true);
newCreature = game.getPermanent(target.getFirstTarget()); Permanent newCreature = null;
} if (player.choose(Outcome.BoostCreature, target, source.getSourceId(), game)) {
for (Permanent attachment : attachments) { newCreature = game.getPermanent(target.getFirstTarget());
if (!attachment.hasSubtype(SubType.AURA, game) && !attachment.hasSubtype(SubType.EQUIPMENT, game)) {
continue;
} }
ContinuousEffect effect = new GainControlTargetEffect(Duration.Custom, true, player.getId()); for (Permanent attachment : attachments) {
effect.setTargetPointer(new FixedTarget(attachment, game)); if (!attachment.hasSubtype(SubType.AURA, game) && !attachment.hasSubtype(SubType.EQUIPMENT, game)) {
game.addEffect(effect, source); continue;
if (newCreature != null) { }
attachment.attachTo(newCreature.getId(), game); ContinuousEffect effect = new GainControlTargetEffect(Duration.Custom, true, player.getId());
effect.setTargetPointer(new FixedTarget(attachment, game));
game.addEffect(effect, source);
if (newCreature != null) {
attachment.attachTo(newCreature.getId(), game);
}
} }
} }
return true; return true;