External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2026-01-22 11:19:55 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

* Fixed that commanders of players were not removed if a player left a game. Fixed a problem that continuous effects of objects of players that left the game were not removed immediately.

Browse source
This commit is contained in:
LevelX2 2018-06-09 14:10:48 +02:00
parent 4ceffd17ef
commit 717308ba12
4 changed files with 135 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Mage.Tests/src/test/java/org/mage/test/commander/FFA3/PlayerLeftTest.java Normal file
View file

@ -0,0 +1,34 @@
/*
* To change this license header, choose License Headers in Project Properties.
* To change this template file, choose Tools | Templates
* and open the template in the editor.
*/
package org.mage.test.commander.FFA3;
import mage.constants.PhaseStep;
import org.junit.Test;
import org.mage.test.serverside.base.CardTestCommander3PlayersFFA;
/**
*
* @author LevelX2
*/
public class PlayerLeftTest extends CardTestCommander3PlayersFFA {
/**
* Check that if a player left the game, it's commander is also removed
*/
@Test
public void TestCommanderRemoved() {
concede(1, PhaseStep.PRECOMBAT_MAIN, playerA);
setStopAt(1, PhaseStep.DECLARE_ATTACKERS);
execute();
assertCommandZoneCount(playerB, "Ob Nixilis of the Black Oath", 1);
assertCommandZoneCount(playerC, "Ob Nixilis of the Black Oath", 1);
assertCommandZoneCount(playerA, "Ob Nixilis of the Black Oath", 0);
}
}

95
Mage.Tests/src/test/java/org/mage/test/multiplayer/PlayerLeftGameRangeAllTest.java
View file

@ -1,4 +1,3 @@
package org.mage.test.multiplayer;
import java.io.FileNotFoundException;
@ -324,4 +323,98 @@ public class PlayerLeftGameRangeAllTest extends CardTestMultiPlayerBase {
assertPermanentCount(playerD, "Silvercoat Lion", 1);
}
/**
* In an EDH game, a player controlling Thalia left the game and the ability
* still lasted for the rest of the game. Gamelog if it helps.
*/
@Test
public void TestThaliaHereticCatharContinuousEffectEndsIfPlayerDies() {
// Player order: A -> D -> C -> B
addCard(Zone.BATTLEFIELD, playerA, "Plains", 3);
// First strike
// Creatures and nonbasic lands your opponents control enter the battlefield tapped.
addCard(Zone.HAND, playerA, "Thalia, Heretic Cathar"); // Creature {2}{W}
addCard(Zone.HAND, playerD, "Lightning Bolt");
addCard(Zone.BATTLEFIELD, playerD, "Mountain", 1);
addCard(Zone.HAND, playerC, "Pillarfield Ox", 1);
addCard(Zone.BATTLEFIELD, playerC, "Plains", 4);
addCard(Zone.HAND, playerB, "Silvercoat Lion", 1);
addCard(Zone.BATTLEFIELD, playerB, "Plains", 2);
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Thalia, Heretic Cathar");
castSpell(2, PhaseStep.PRECOMBAT_MAIN, playerD, "Lightning Bolt", playerA);
castSpell(3, PhaseStep.PRECOMBAT_MAIN, playerC, "Pillarfield Ox");
castSpell(4, PhaseStep.PRECOMBAT_MAIN, playerB, "Silvercoat Lion");
setStopAt(4, PhaseStep.BEGIN_COMBAT);
execute();
assertGraveyardCount(playerD, "Lightning Bolt", 1);
assertLife(playerA, -1);
Assert.assertFalse("Player D is no longer in the game", playerA.isInGame());
assertPermanentCount(playerC, "Pillarfield Ox", 1);
assertPermanentCount(playerB, "Silvercoat Lion", 1);
assertTapped("Pillarfield Ox", false);
assertTapped("Silvercoat Lion", false);
}
/**
* In an EDH game, a player controlling Thalia left the game and the ability
* still lasted for the rest of the game. Gamelog if it helps.
*/
@Test
public void TestThaliaHereticCatharContinuousEffectEndsIfPlayerConcedes() {
// Player order: A -> D -> C -> B
addCard(Zone.BATTLEFIELD, playerA, "Plains", 3);
// First strike
// Creatures and nonbasic lands your opponents control enter the battlefield tapped.
addCard(Zone.HAND, playerA, "Thalia, Heretic Cathar"); // Creature {2}{W}
addCard(Zone.HAND, playerD, "Juggernaut");
addCard(Zone.BATTLEFIELD, playerD, "Plains", 4);
addCard(Zone.HAND, playerC, "Pillarfield Ox", 1);
addCard(Zone.BATTLEFIELD, playerC, "Plains", 4);
addCard(Zone.HAND, playerB, "Silvercoat Lion", 1);
addCard(Zone.BATTLEFIELD, playerB, "Plains", 2);
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Thalia, Heretic Cathar");
concede(2, PhaseStep.PRECOMBAT_MAIN, playerA);
castSpell(2, PhaseStep.PRECOMBAT_MAIN, playerD, "Juggernaut");
castSpell(3, PhaseStep.PRECOMBAT_MAIN, playerC, "Pillarfield Ox");
castSpell(4, PhaseStep.PRECOMBAT_MAIN, playerB, "Silvercoat Lion");
setStopAt(4, PhaseStep.BEGIN_COMBAT);
execute();
Assert.assertFalse("Player D is no longer in the game", playerA.isInGame());
assertLife(playerA, 2);
assertPermanentCount(playerD, "Juggernaut", 1);
assertPermanentCount(playerC, "Pillarfield Ox", 1);
assertPermanentCount(playerB, "Silvercoat Lion", 1);
assertTapped("Pillarfield Ox", false);
assertTapped("Silvercoat Lion", false);
assertTapped("Juggernaut", false);
}
}

7
Mage.Tests/src/test/java/org/mage/test/serverside/base/CardTestCommander3PlayersFFA.java
View file

@ -1,4 +1,3 @@
package org.mage.test.serverside.base;
import java.io.FileNotFoundException;
@ -25,9 +24,9 @@ public abstract class CardTestCommander3PlayersFFA extends CardTestPlayerAPIImpl
@Override
protected Game createNewGameAndPlayers() throws GameException, FileNotFoundException {
Game game = new CommanderFreeForAll(MultiplayerAttackOption.MULTIPLE, RangeOfInfluence.ONE, 0, 40);
playerA = createPlayer(game, playerA, "PlayerA");
playerB = createPlayer(game, playerB, "PlayerB");
playerC = createPlayer(game, playerC, "PlayerC");
playerA = createPlayer(game, playerA, "PlayerA", deckNameA);
playerB = createPlayer(game, playerB, "PlayerB", deckNameB);
playerC = createPlayer(game, playerC, "PlayerC", deckNameC);
return game;
}