External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-20 10:40:06 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix superfluous warnings in reminder text verify check (related to ddcc6f21)

Browse source
This commit is contained in:
xenohedron 2023-09-11 20:38:28 -04:00
parent 9a0143be0e
commit 687fe0bc77
3 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Mage.Sets/src/mage/cards/a/AgathasChampion.java
View file

@ -42,7 +42,8 @@ public final class AgathasChampion extends CardImpl {
this.addAbility(new ConditionalInterveningIfTriggeredAbility( this.addAbility(new ConditionalInterveningIfTriggeredAbility(
trigger, trigger,
BargainedCondition.instance, BargainedCondition.instance,
"When {this} enters the battlefield, if it was bargained, it fights up to one target creature you don't control." "When {this} enters the battlefield, if it was bargained, it fights up to one target creature you don't control." +
" <i>(Each deals damage equal to its power to the other.)</i>"
)); ));
} }

1
Mage.Sets/src/mage/cards/b/BelligerentOfTheBall.java
View file

@ -41,6 +41,7 @@ public final class BelligerentOfTheBall extends CardImpl {
CelebrationCondition.instance, "At the beginning of combat on your turn, if two or more nonland " CelebrationCondition.instance, "At the beginning of combat on your turn, if two or more nonland "
+ "permanents entered the battlefield under your control this turn, target creature you control " + "permanents entered the battlefield under your control this turn, target creature you control "
+ "gets +1/+0 and gains menace until end of turn." + "gets +1/+0 and gains menace until end of turn."
+ " <i>(It can't be blocked except by two or more creatures.)</i>"
); );
ability.addEffect(new GainAbilityTargetEffect(new MenaceAbility(false))); ability.addEffect(new GainAbilityTargetEffect(new MenaceAbility(false)));
ability.addTarget(new TargetControlledCreaturePermanent()); ability.addTarget(new TargetControlledCreaturePermanent());

10
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -2034,17 +2034,17 @@ public class VerifyCardDataTest {
// special check: missing or wrong ability/effect hints // special check: missing or wrong ability/effect hints
Map<Class, String> hints = new HashMap<>(); Map<Class, String> hints = new HashMap<>();
hints.put(FightTargetsEffect.class, "each deals damage equal to its power to the other"); hints.put(FightTargetsEffect.class, "Each deals damage equal to its power to the other");
hints.put(MenaceAbility.class, "can't be blocked except by two or more"); hints.put(MenaceAbility.class, "can't be blocked except by two or more");
hints.put(ScryEffect.class, "look at the top card of your library. You may put that card on the bottom of your library"); hints.put(ScryEffect.class, "Look at the top card of your library. You may put that card on the bottom of your library");
hints.put(EquipAbility.class, "equip only as a sorcery."); hints.put(EquipAbility.class, "Equip only as a sorcery.");
hints.put(WardAbility.class, "becomes the target of a spell or ability an opponent controls"); hints.put(WardAbility.class, "becomes the target of a spell or ability an opponent controls");
hints.put(ProliferateEffect.class, "choose any number of permanents and/or players, then give each another counter of each kind already there."); hints.put(ProliferateEffect.class, "Choose any number of permanents and/or players, then give each another counter of each kind already there.");
for (Class objectClass : hints.keySet()) { for (Class objectClass : hints.keySet()) {
String objectHint = hints.get(objectClass); String objectHint = hints.get(objectClass);
// ability/effect must have description or not // ability/effect must have description or not
boolean needHint = refLowerText.contains(objectHint); boolean needHint = ref.text.contains(objectHint);
boolean haveHint = card.getRules().stream().anyMatch(rule -> rule.contains(objectHint)); boolean haveHint = card.getRules().stream().anyMatch(rule -> rule.contains(objectHint));
if (needHint != haveHint) { if (needHint != haveHint) {
warn(card, "card have " + objectClass.getSimpleName() + " but hint is wrong (it must be " + (needHint ? "enabled" : "disabled") + ")"); warn(card, "card have " + objectClass.getSimpleName() + " but hint is wrong (it must be " + (needHint ? "enabled" : "disabled") + ")");