diff --git a/Mage.Client/pom.xml b/Mage.Client/pom.xml index d27d1ff605e..6f7b308bc65 100644 --- a/Mage.Client/pom.xml +++ b/Mage.Client/pom.xml @@ -87,14 +87,6 @@ jetlang 0.2.23 - - - - com.amazonaws - aws-java-sdk-s3 - 1.12.78 - - com.jgoodies diff --git a/Mage.Client/src/main/java/mage/client/remote/CallbackClientImpl.java b/Mage.Client/src/main/java/mage/client/remote/CallbackClientImpl.java index 3fb8dcea16f..cc1be98996a 100644 --- a/Mage.Client/src/main/java/mage/client/remote/CallbackClientImpl.java +++ b/Mage.Client/src/main/java/mage/client/remote/CallbackClientImpl.java @@ -257,10 +257,7 @@ public class CallbackClientImpl implements CallbackClient { if (panel != null) { Session session = SessionHandler.getSession(); if (session.isJsonLogActive()) { - UUID gameId = callback.getObjectId(); appendJsonEvent("GAME_OVER", callback.getObjectId(), message); - String logFileName = "game-" + gameId + ".json"; - S3Uploader.upload(logFileName, gameId.toString()); } panel.endMessage(callback.getMessageId(), message.getGameView(), message.getOptions(), message.getMessage()); } diff --git a/Mage.Client/src/main/java/mage/client/remote/S3Uploader.java b/Mage.Client/src/main/java/mage/client/remote/S3Uploader.java deleted file mode 100644 index 85968f6ea03..00000000000 --- a/Mage.Client/src/main/java/mage/client/remote/S3Uploader.java +++ /dev/null @@ -1,46 +0,0 @@ -package mage.client.remote; - -import com.amazonaws.AmazonClientException; -import com.amazonaws.auth.BasicAWSCredentials; -import com.amazonaws.services.s3.transfer.TransferManager; -import com.amazonaws.services.s3.transfer.Upload; -import org.apache.log4j.Logger; - -import java.io.File; - -public class S3Uploader { - - private static final Logger logger = Logger.getLogger(S3Uploader.class); - - public static Boolean upload(String filePath, String keyName) throws Exception { - String existingBucketName = System.getenv("S3_BUCKET") != null ? System.getenv("S3_BUCKET") - : "xmage-game-logs-dev"; - - String accessKeyId = System.getenv("AWS_ACCESS_ID"); - String secretKeyId = System.getenv("AWS_SECRET_KEY"); - - if (accessKeyId == null || accessKeyId.isEmpty() - || secretKeyId == null || secretKeyId.isEmpty() - || existingBucketName.isEmpty()) { - logger.info("Aborting json log sync."); - return false; - } - - String path = new File("./" + filePath).getCanonicalPath(); - logger.info("Syncing " + path + " to bucket: " + existingBucketName + " with AWS Access Id: " + accessKeyId); - - BasicAWSCredentials awsCreds = new BasicAWSCredentials(accessKeyId, secretKeyId); - TransferManager tm = new TransferManager(awsCreds); - Upload upload = tm.upload(existingBucketName, "/game/" + keyName + ".json", new File(path)); - - try { - upload.waitForUploadResult(); - logger.info("Sync Complete For " + path + " to bucket: " + existingBucketName + " with AWS Access Id: " + accessKeyId); - new File(path); - return true; - } catch (AmazonClientException amazonClientException) { - logger.fatal("Unable to upload file, upload was aborted.", amazonClientException); - return false; - } - } -} diff --git a/Mage.Server/pom.xml b/Mage.Server/pom.xml index ff104474d0e..2acdc206ab3 100644 --- a/Mage.Server/pom.xml +++ b/Mage.Server/pom.xml @@ -218,7 +218,7 @@ org.apache.shiro shiro-core - 1.8.0 + 1.13.0 javax.mail diff --git a/Mage.Server/src/main/java/mage/server/SessionManagerImpl.java b/Mage.Server/src/main/java/mage/server/SessionManagerImpl.java index a3fe09ef6b6..76bbb3d755e 100644 --- a/Mage.Server/src/main/java/mage/server/SessionManagerImpl.java +++ b/Mage.Server/src/main/java/mage/server/SessionManagerImpl.java @@ -8,7 +8,6 @@ import mage.util.ThreadUtils; import org.apache.log4j.Logger; import org.jboss.remoting.callback.InvokerCallbackHandler; -import javax.annotation.Nonnull; import java.util.Optional; import java.util.concurrent.ConcurrentHashMap; @@ -29,7 +28,7 @@ public class SessionManagerImpl implements SessionManager { } @Override - public Optional getSession(@Nonnull String sessionId) { + public Optional getSession(String sessionId) { return Optional.ofNullable(sessions.getOrDefault(sessionId, null)); } @@ -180,12 +179,12 @@ public class SessionManagerImpl implements SessionManager { } @Override - public boolean isValidSession(@Nonnull String sessionId) { + public boolean isValidSession(String sessionId) { return sessions.containsKey(sessionId); } @Override - public Optional getUser(@Nonnull String sessionId) { + public Optional getUser(String sessionId) { Session session = sessions.get(sessionId); if (session != null) { return managerFactory.userManager().getUser(sessions.get(sessionId).getUserId()); diff --git a/Mage.Server/src/main/java/mage/server/managers/SessionManager.java b/Mage.Server/src/main/java/mage/server/managers/SessionManager.java index c5d1559b068..181ea1b28a9 100644 --- a/Mage.Server/src/main/java/mage/server/managers/SessionManager.java +++ b/Mage.Server/src/main/java/mage/server/managers/SessionManager.java @@ -7,12 +7,11 @@ import mage.server.Session; import mage.server.User; import org.jboss.remoting.callback.InvokerCallbackHandler; -import javax.annotation.Nonnull; import java.util.Optional; public interface SessionManager { - Optional getSession(@Nonnull String sessionId); + Optional getSession(String sessionId); void createSession(String sessionId, InvokerCallbackHandler callbackHandler); @@ -37,9 +36,9 @@ public interface SessionManager { boolean checkAdminAccess(String sessionId); - boolean isValidSession(@Nonnull String sessionId); + boolean isValidSession(String sessionId); - Optional getUser(@Nonnull String sessionId); + Optional getUser(String sessionId); boolean extendUserSession(String sessionId, String pingInfo); diff --git a/Mage/pom.xml b/Mage/pom.xml index f148552c45f..cd79961ea6b 100644 --- a/Mage/pom.xml +++ b/Mage/pom.xml @@ -25,7 +25,7 @@ com.google.protobuf protobuf-java - 3.19.3 + 3.25.8 @@ -55,7 +55,7 @@ - com.google.protobuf:protoc:3.18.0 + com.google.protobuf:protoc:3.25.8 ${project.basedir}/src/main/proto diff --git a/pom.xml b/pom.xml index d7b20e1784f..a630bfc265d 100644 --- a/pom.xml +++ b/pom.xml @@ -349,7 +349,7 @@ com.google.guava guava - 30.1.1-jre + 33.4.8-jre @@ -373,7 +373,7 @@ org.jsoup jsoup - 1.14.3 + 1.21.1