External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2026-01-18 01:10:00 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Modal Double Faces cards fixes:

Browse source 
* Fixed that mdf card can duplicate triggers (example: Skyclave Cleric, see #7187);
 * Fixed that mdf card can raise triggers from another side (example: Kazandu Mammoth, see #7180);
This commit is contained in:
Oleg Agafonov 2020-11-18 02:04:32 +04:00
parent 6dcf7a2e53
commit 656653f38b
5 changed files with 132 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

44
Mage.Tests/src/test/java/org/mage/test/cards/cost/modaldoublefaces/ModalDoubleFacesCardsTest.java
View file

@ -549,4 +549,48 @@ public class ModalDoubleFacesCardsTest extends CardTestPlayerBase {
assertPermanentCount(playerA, "Balduvian Bears", 2);
}
@Test
public void test_ETB_OnlySideCardsCanAddAbilitiesToGame() {
// possible bug: double triggers (loadCard adds abilities from main + side cards instead side card only)
// https://github.com/magefree/mage/issues/7187
// Skyclave Cleric
// creature 1/3
// When Skyclave Cleric enters the battlefield, you gain 2 life.
addCard(Zone.HAND, playerA, "Skyclave Cleric"); // {1}{W}
addCard(Zone.BATTLEFIELD, playerA, "Plains", 2);
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Skyclave Cleric");
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
assertAllCommandsUsed();
assertLife(playerA, 20 + 2); // +2 from 1 etb trigger
}
@Test
public void test_ETB_OnlyActualSideCardCanRaiseTriggers() {
// possible bug: you play one card but game raise triggers from another side too
// https://github.com/magefree/mage/issues/7180
// Kazandu Mammoth
// creature 3/3
// Landfall — Whenever a land enters the battlefield under your control, Kazandu Mammoth gets +2/+2 until end of turn.
//
// Kazandu Valley
// land
addCard(Zone.HAND, playerA, "Kazandu Mammoth"); // {1}{G}{G}
// play land, but no landfall triggers from other side
playLand(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Kazandu Valley");
checkStackSize("no triggers", 1, PhaseStep.PRECOMBAT_MAIN, playerA, 0);
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
assertAllCommandsUsed();
}
}

9
Mage.Tests/src/test/java/org/mage/test/player/TestPlayer.java
View file

@ -1149,7 +1149,11 @@ public class TestPlayer implements Player {
}
private void printAbilities(Game game, List<? extends Ability> abilities) {
System.out.println("Total abilities: " + (abilities != null ? abilities.size() : 0));
printAbilities("Total abilities", game, abilities);
}
private void printAbilities(String info, Game game, List<? extends Ability> abilities) {
System.out.println(info + ": " + (abilities != null ? abilities.size() : 0));
if (abilities == null) {
return;
}
@ -1484,6 +1488,9 @@ public class TestPlayer implements Player {
}
private void assertStackSize(PlayerAction action, Game game, int needStackSize) {
if (game.getStack().size() != needStackSize) {
printAbilities("Current stack", game, game.getStack().stream().map(StackObject::getStackAbility).collect(Collectors.toList()));
}
Assert.assertEquals(action.getActionName() + " - stack size must be " + needStackSize + " but is " + game.getStack().size(), needStackSize, game.getStack().size());
}