External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-27 22:12:03 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix #12575

Browse source 
add test for AddManaInAnyCombinationEffect

cleanup Grand Warlord Radha, add test

simplify some abilities to common class

remove unused constructors
This commit is contained in:
xenohedron 2024-07-25 01:35:20 -04:00
parent be3065789d
commit 5cc4901580
8 changed files with 104 additions and 354 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Mage/src/main/java/mage/abilities/effects/mana/AddManaInAnyCombinationEffect.java
View file

@ -19,7 +19,7 @@ import java.util.*;
*/
public class AddManaInAnyCombinationEffect extends ManaEffect {
private ArrayList<ColoredManaSymbol> manaSymbols = new ArrayList<>();
private List<ColoredManaSymbol> manaSymbols = new ArrayList<>();
private final DynamicValue amount;
private final DynamicValue netAmount;
@ -45,21 +45,6 @@ public class AddManaInAnyCombinationEffect extends ManaEffect {
this.netAmount = netAmount;
}
public AddManaInAnyCombinationEffect(int amount, String text) {
this(amount);
this.staticText = text;
}
public AddManaInAnyCombinationEffect(int amount, String text, ColoredManaSymbol... coloredManaSymbols) {
this(amount, coloredManaSymbols);
this.staticText = text;
}
public AddManaInAnyCombinationEffect(DynamicValue amount, DynamicValue netAmount, String text, ColoredManaSymbol... coloredManaSymbols) {
this(amount, netAmount, coloredManaSymbols);
this.staticText = text;
}
protected AddManaInAnyCombinationEffect(final AddManaInAnyCombinationEffect effect) {
super(effect);
this.manaSymbols = effect.manaSymbols;

2
Mage/src/main/java/mage/abilities/effects/mana/ManaEffect.java
View file

@ -19,7 +19,7 @@ import java.util.Set;
*/
public abstract class ManaEffect extends OneShotEffect {
public ManaEffect() {
protected ManaEffect() {
super(Outcome.PutManaInPool);
}