External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2026-01-26 21:29:17 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Gain abilities - improved combo support with Evoke, Dash and Prowl (example: Hunting Velociraptor, fixed #11714) (#12237)

Browse source
This commit is contained in:
jimga150 2024-05-09 01:26:42 -04:00 • committed by GitHub
parent 432063d5bd
commit 551d5d8633
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 32 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Mage.Tests/src/test/java/org/mage/test/cards/abilities/keywords/ProwlTest.java
View file

@ -6,7 +6,7 @@ import org.junit.Test;
import org.mage.test.serverside.base.CardTestPlayerBase;
/**
* @author escplan9 (Derek Monturo - dmontur1 at gmail dot com)
* @author escplan9 (Derek Monturo - dmontur1 at gmail dot com) and jimga150
*/
public class ProwlTest extends CardTestPlayerBase {
@ -74,4 +74,34 @@ public class ProwlTest extends CardTestPlayerBase {
assertPermanentCount(playerA, "Goblin Warchief", 1);
assertPermanentCount(playerA, "Auntie's Snitch", 1);
}
/*
* Reported bug: you can't cast something for its prowl cost if you could not afford to cast it for its normal cost. The game won't allow me to put the creature on the stack at all.
* It seems it is only in the case of Hunting Velociraptor and not Prowl in general.
* GainAbilityControlledSpellsEffect not adding AlternativeSourceCosts in time to check playable
*/
@Test
public void test_ProwlWithGainAbilityControlledSpellsEffect() {
// {2}{R} Creature — Dinosaur (3/2)
// Dinosaur spells you cast have prowl {2}{R}.
addCard(Zone.BATTLEFIELD, playerA, "Hunting Velociraptor");
addCard(Zone.BATTLEFIELD, playerA, "Mountain", 3);
addCard(Zone.HAND, playerA, "Thrasta, Tempest's Roar");
// prepare prowl condition
checkPlayableAbility("can't", 1, PhaseStep.PRECOMBAT_MAIN, playerA, "Cast Thrasta", false);
attack(1, playerA, "Hunting Velociraptor");
checkPlayableAbility("must play", 1, PhaseStep.POSTCOMBAT_MAIN, playerA, "Cast Thrasta", true);
castSpell(1, PhaseStep.POSTCOMBAT_MAIN, playerA, "Thrasta, Tempest's Roar");
setChoice(playerA, true); // choosing to pay prowl cost
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
assertLife(playerB, currentGame.getStartingLife() - 3);
assertPermanentCount(playerA, "Hunting Velociraptor", 1);
assertPermanentCount(playerA, "Thrasta, Tempest's Roar", 1);
}
}

2
Mage/src/main/java/mage/players/PlayerImpl.java
View file

@ -3737,7 +3737,7 @@ public abstract class PlayerImpl implements Player, Serializable {
// TODO: Why is the "sourceObject instanceof Permanent" in there?
if (sourceObject != null && !(sourceObject instanceof Permanent)) {
Ability copyAbility; // for alternative cost and reduce tries
for (Ability alternateSourceCostsAbility : sourceObject.getAbilities()) {
for (Ability alternateSourceCostsAbility : sourceObject.getAbilities(game)) {
// if cast for noMana no Alternative costs are allowed
if (alternateSourceCostsAbility instanceof AlternativeSourceCosts) {
if (((AlternativeSourceCosts) alternateSourceCostsAbility).isAvailable(ability, game)) {