External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2026-01-09 12:22:10 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: simplify DistributeCountersEffect constructors

Browse source
This commit is contained in:
xenohedron 2024-11-29 03:07:41 -05:00
parent d12b34e05b
commit 4edce76732
33 changed files with 53 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Mage/src/main/java/mage/abilities/effects/common/counter/DistributeCountersEffect.java
View file

@ -1,4 +1,3 @@
package mage.abilities.effects.common.counter;
import mage.abilities.Ability;
@ -24,22 +23,24 @@ public class DistributeCountersEffect extends OneShotEffect {
private final CounterType counterType;
private final DynamicValue amount;
private final boolean removeAtEndOfTurn;
private boolean removeAtEndOfTurn = false;
private final String targetDescription;
/**
* Distribute +1/+1 counters among targets
*/
public DistributeCountersEffect(int amount, String targetDescription) {
this(CounterType.P1P1, StaticValue.get(amount), targetDescription);
}
public DistributeCountersEffect(CounterType counterType, int amount, String targetDescription) {
this(counterType, amount, false, targetDescription);
this(counterType, StaticValue.get(amount), targetDescription);
}
public DistributeCountersEffect(CounterType counterType, int amount, boolean removeAtEndOfTurn, String targetDescription) {
this(counterType, StaticValue.get(amount), removeAtEndOfTurn, targetDescription);
}
public DistributeCountersEffect(CounterType counterType, DynamicValue amount, boolean removeAtEndOfTurn, String targetDescription) {
public DistributeCountersEffect(CounterType counterType, DynamicValue amount, String targetDescription) {
super(Outcome.BoostCreature);
this.counterType = counterType;
this.amount = amount;
this.removeAtEndOfTurn = removeAtEndOfTurn;
this.targetDescription = targetDescription;
}
@ -56,6 +57,11 @@ public class DistributeCountersEffect extends OneShotEffect {
return new DistributeCountersEffect(this);
}
public DistributeCountersEffect withRemoveAtEndOfTurn() {
this.removeAtEndOfTurn = true;
return this;
}
@Override
public boolean apply(Game game, Ability source) {
if (!source.getTargets().isEmpty()) {
@ -99,7 +105,7 @@ class RemoveCountersAtEndOfTurn extends OneShotEffect {
private final CounterType counterType;
public RemoveCountersAtEndOfTurn(CounterType counterType) {
RemoveCountersAtEndOfTurn(CounterType counterType) {
super(Outcome.Detriment);
this.counterType = counterType;
String name = counterType.getName();