External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-20 02:30:08 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

When you cast this spell - fixed that it required double cost for cards with alternative costs like Evoke (example: Nulldrifter, #12843)

Browse source
This commit is contained in:
Oleg Agafonov 2024-12-14 21:17:24 +04:00
parent 38b54beb54
commit 4bce1e0a9a
2 changed files with 167 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

160
Mage.Tests/src/test/java/org/mage/test/cards/single/mh3/NulldrifterTest.java Normal file
View file

@ -0,0 +1,160 @@
package org.mage.test.cards.single.mh3;
import mage.constants.PhaseStep;
import mage.constants.Zone;
import org.junit.Ignore;
import org.junit.Test;
import org.mage.test.serverside.base.CardTestPlayerBaseWithAIHelps;
/**
* @author JayDi85
*/
public class NulldrifterTest extends CardTestPlayerBaseWithAIHelps {
@Test
public void test_AllMana_UseNormalCost() {
// When you cast this spell, draw two cards.
// Evoke {2}{U} (You may cast this spell for its evoke cost. If you do, it’s sacrificed when it enters.)
addCard(Zone.HAND, playerA, "Nulldrifter", 1); // {7}
addCard(Zone.BATTLEFIELD, playerA, "Island", 7);
// select normal cost
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Nulldrifter");
setChoice(playerA, "Cast with no alternative cost");
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
assertPermanentCount(playerA, "Nulldrifter", 1);
assertGraveyardCount(playerA, "Nulldrifter", 0);
assertHandCount(playerA, 2);
assertTappedCount("Island", true, 7);
}
@Test
public void test_AllMana_UseEvokeCost_Human() {
// When you cast this spell, draw two cards.
// Evoke {2}{U} (You may cast this spell for its evoke cost. If you do, it’s sacrificed when it enters.)
addCard(Zone.HAND, playerA, "Nulldrifter", 1); // {7}
addCard(Zone.BATTLEFIELD, playerA, "Island", 7);
// select evoke cost
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Nulldrifter");
setChoice(playerA, "Cast with Evoke alternative cost");
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
assertPermanentCount(playerA, "Nulldrifter", 0);
assertGraveyardCount(playerA, "Nulldrifter", 1);
assertHandCount(playerA, 2);
assertTappedCount("Island", true, 3);
}
@Test
@Ignore // TODO: implement alternative cost choose by AI instead random
public void test_AllMana_UseEvokeCost_AI() {
// When you cast this spell, draw two cards.
// Evoke {2}{U} (You may cast this spell for its evoke cost. If you do, it’s sacrificed when it enters.)
addCard(Zone.HAND, playerA, "Nulldrifter", 1); // {7}
addCard(Zone.BATTLEFIELD, playerA, "Island", 7);
// make sure AI will use evoke cost
aiPlayStep(1, PhaseStep.PRECOMBAT_MAIN, playerA);
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
assertPermanentCount(playerA, "Nulldrifter", 0);
assertGraveyardCount(playerA, "Nulldrifter", 1);
assertHandCount(playerA, 2);
assertTappedCount("Island", true, 3);
}
@Test
public void test_OnlyEvoke_UseEvokeCost_Human() {
// When you cast this spell, draw two cards.
// Evoke {2}{U} (You may cast this spell for its evoke cost. If you do, it’s sacrificed when it enters.)
addCard(Zone.HAND, playerA, "Nulldrifter", 1); // {7}
addCard(Zone.BATTLEFIELD, playerA, "Island", 3);
// select evoke cost
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Nulldrifter");
setChoice(playerA, "Cast with Evoke alternative cost");
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
assertPermanentCount(playerA, "Nulldrifter", 0);
assertGraveyardCount(playerA, "Nulldrifter", 1);
assertHandCount(playerA, 2);
assertTappedCount("Island", true, 3);
}
@Test
@Ignore // TODO: implement alternative cost choose by AI instead random
public void test_OnlyEvoke_UseEvokeCost_AI() {
// When you cast this spell, draw two cards.
// Evoke {2}{U} (You may cast this spell for its evoke cost. If you do, it’s sacrificed when it enters.)
addCard(Zone.HAND, playerA, "Nulldrifter", 1); // {7}
addCard(Zone.BATTLEFIELD, playerA, "Island", 3);
// make sure AI will use evoke cost
aiPlayStep(1, PhaseStep.PRECOMBAT_MAIN, playerA);
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
assertPermanentCount(playerA, "Nulldrifter", 0);
assertGraveyardCount(playerA, "Nulldrifter", 1);
assertHandCount(playerA, 2);
assertTappedCount("Island", true, 3);
}
@Test
public void test_OnlyNormalCost_UseNormalCost_Human() {
// When you cast this spell, draw two cards.
// Evoke {2}{U} (You may cast this spell for its evoke cost. If you do, it’s sacrificed when it enters.)
addCard(Zone.HAND, playerA, "Nulldrifter", 1); // {7}
addCard(Zone.BATTLEFIELD, playerA, "Mountain", 7);
// select normal cost
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Nulldrifter");
setChoice(playerA, "Cast with no alternative cost");
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
assertPermanentCount(playerA, "Nulldrifter", 1);
assertGraveyardCount(playerA, "Nulldrifter", 0);
assertHandCount(playerA, 2);
assertTappedCount("Mountain", true, 7);
}
@Test
@Ignore // TODO: implement alternative cost choose by AI instead random
public void test_OnlyNormalCost_UseNormalCost_AI() {
// When you cast this spell, draw two cards.
// Evoke {2}{U} (You may cast this spell for its evoke cost. If you do, it’s sacrificed when it enters.)
addCard(Zone.HAND, playerA, "Nulldrifter", 1); // {7}
addCard(Zone.BATTLEFIELD, playerA, "Mountain", 7);
// make sure AI will use normal cost
aiPlayStep(1, PhaseStep.PRECOMBAT_MAIN, playerA);
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
assertPermanentCount(playerA, "Nulldrifter", 1);
assertGraveyardCount(playerA, "Nulldrifter", 0);
assertHandCount(playerA, 2);
assertTappedCount("Mountain", true, 7);
}
}

8
Mage/src/main/java/mage/abilities/AbilityImpl.java
View file

@ -466,10 +466,16 @@ public abstract class AbilityImpl implements Ability {
}
/**
* @return true if choices for the activation were made (can be to activate with the regular cost)
* @return false to stop activation process, e.g. on wrong data/choices
*/
@Override
public boolean activateAlternateOrAdditionalCosts(MageObject sourceObject, Set<MageIdentifier> allowedIdentifiers, boolean noMana, Player controller, Game game) {
// alternative or additional costs supported for spells or activated abilities only
if (!this.getAbilityType().isActivatedAbility()
&& !this.getAbilityType().isPlayCardAbility()) {
return true;
}
boolean canUseAlternativeCost = true;
boolean canUseAdditionalCost = true;