diff --git a/Mage.Client/src/main/java/mage/client/dialog/PreferencesDialog.java b/Mage.Client/src/main/java/mage/client/dialog/PreferencesDialog.java index 1b9e9881bad..6f69eeed8fc 100644 --- a/Mage.Client/src/main/java/mage/client/dialog/PreferencesDialog.java +++ b/Mage.Client/src/main/java/mage/client/dialog/PreferencesDialog.java @@ -79,6 +79,7 @@ public class PreferencesDialog extends javax.swing.JDialog { public static final String KEY_CARD_IMAGES_USE_DEFAULT = "cardImagesUseDefault"; public static final String KEY_CARD_IMAGES_PATH = "cardImagesPath"; public static final String KEY_CARD_IMAGES_THREADS = "cardImagesThreads"; + public static final String KEY_CARD_IMAGES_THREADS_DEFAULT = "3"; public static final String KEY_CARD_IMAGES_SAVE_TO_ZIP = "cardImagesSaveToZip"; public static final String KEY_CARD_IMAGES_PREF_LANGUAGE = "cardImagesPreferedImageLaguage"; @@ -3465,7 +3466,7 @@ public class PreferencesDialog extends javax.swing.JDialog { updateCache(KEY_CARD_IMAGES_PATH, path); } load(prefs, dialog.cbSaveToZipFiles, KEY_CARD_IMAGES_SAVE_TO_ZIP, "true"); - dialog.cbNumberOfDownloadThreads.setSelectedItem(MageFrame.getPreferences().get(KEY_CARD_IMAGES_THREADS, "10")); + dialog.cbNumberOfDownloadThreads.setSelectedItem(MageFrame.getPreferences().get(KEY_CARD_IMAGES_THREADS, KEY_CARD_IMAGES_THREADS_DEFAULT)); dialog.cbPreferedImageLanguage.setSelectedItem(MageFrame.getPreferences().get(KEY_CARD_IMAGES_PREF_LANGUAGE, CardLanguage.ENGLISH.getCode())); // rendering settings @@ -3762,10 +3763,9 @@ public class PreferencesDialog extends javax.swing.JDialog { if (CACHE.containsKey(key)) { return CACHE.get(key); } else { - Preferences prefs = MageFrame.getPreferences(); - String value = prefs.get(key, def); + String value = MageFrame.getPreferences().get(key, def); if (value == null) { - return null; + return def; } CACHE.put(key, value); return value; diff --git a/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java b/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java index 6c43bb0a584..9211ba721a4 100644 --- a/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java +++ b/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java @@ -51,18 +51,18 @@ public class DownloadPicturesService extends DefaultBoundedRangeModel implements private static final int MAX_ERRORS_COUNT_BEFORE_CANCEL = 50; - private DownloadImagesDialog uiDialog; + private final DownloadImagesDialog uiDialog; private boolean needCancel; private int errorCount; private int cardIndex; private List cardsAll; private List cardsMissing; - private List cardsDownloadQueue; + private final List cardsDownloadQueue; private int missingCardsCount = 0; private int missingTokensCount = 0; - private List selectedSets = new ArrayList<>(); + private final List selectedSets = new ArrayList<>(); private static CardImageSource selectedSource; private final Object sync = new Object(); @@ -617,7 +617,7 @@ public class DownloadPicturesService extends DefaultBoundedRangeModel implements uiDialog.getProgressBar().setString("Preparing download list..."); if (selectedSource.prepareDownloadList(this, cardsDownloadQueue)) { update(0, cardsDownloadQueue.size()); - int numberOfThreads = Integer.parseInt(PreferencesDialog.getCachedValue(PreferencesDialog.KEY_CARD_IMAGES_THREADS, "10")); + int numberOfThreads = Integer.parseInt(PreferencesDialog.getCachedValue(PreferencesDialog.KEY_CARD_IMAGES_THREADS, PreferencesDialog.KEY_CARD_IMAGES_THREADS_DEFAULT)); ExecutorService executor = Executors.newFixedThreadPool(numberOfThreads); for (int i = 0; i < cardsDownloadQueue.size() && !this.isNeedCancel(); i++) { try {