From 3e1312064fe44587886b8a7f9d0e42d8764000ab Mon Sep 17 00:00:00 2001 From: Marc Zwart Date: Tue, 20 Mar 2018 16:04:10 +0100 Subject: [PATCH] removed dangerous instance of double checked locking in settingsmanager --- .../org/mage/plugins/card/properties/SettingsManager.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Mage.Client/src/main/java/org/mage/plugins/card/properties/SettingsManager.java b/Mage.Client/src/main/java/org/mage/plugins/card/properties/SettingsManager.java index 075a3d9008b..c7a6b87d62c 100644 --- a/Mage.Client/src/main/java/org/mage/plugins/card/properties/SettingsManager.java +++ b/Mage.Client/src/main/java/org/mage/plugins/card/properties/SettingsManager.java @@ -12,13 +12,9 @@ public class SettingsManager { private static SettingsManager settingsManager = null; - public static SettingsManager getIntance() { + public static synchronized SettingsManager getIntance() { if (settingsManager == null) { - synchronized (SettingsManager.class) { - if (settingsManager == null) { - settingsManager = new SettingsManager(); - } - } + settingsManager = new SettingsManager(); } return settingsManager; }