Added ConditionalPreventionEffect to support prevention effects with conditions (#5738)

Mage/src/main/java/mage/abilities/decorator/ConditionalContinuousEffect.java

@@ -1,9 +1,5 @@
 package mage.abilities.decorator;
 
-import java.util.EnumSet;
-import java.util.List;
-import java.util.Set;
-import java.util.UUID;
 import mage.abilities.Ability;
 import mage.abilities.Mode;
 import mage.abilities.condition.Condition;
@@ -11,11 +7,14 @@ import mage.abilities.condition.FixedCondition;
 import mage.abilities.condition.LockedInCondition;
 import mage.abilities.effects.ContinuousEffect;
 import mage.abilities.effects.ContinuousEffectImpl;
-import mage.constants.DependencyType;
-import mage.constants.Duration;
-import mage.constants.Layer;
-import mage.constants.SubLayer;
+import mage.constants.*;
 import mage.game.Game;
+import org.junit.Assert;
+
+import java.util.EnumSet;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
 
 /**
  * Adds condition to {@link ContinuousEffect}. Acts as decorator.
@@ -48,6 +47,17 @@ public class ConditionalContinuousEffect extends ContinuousEffectImpl {
         this.otherwiseEffect = otherwiseEffect;
         this.baseCondition = condition;
         this.staticText = text;
+
+        // checks for compatibility
+        if (effect != null && !effect.getEffectType().equals(EffectType.CONTINUOUS)) {
+            Assert.fail("ConditionalContinuousEffect supports only " + EffectType.CONTINUOUS.toString() + " but found " + effect.getEffectType().toString());
+        }
+        if (otherwiseEffect != null && !otherwiseEffect.getEffectType().equals(EffectType.CONTINUOUS)) {
+            Assert.fail("ConditionalContinuousEffect supports only " + EffectType.CONTINUOUS.toString() + " but found " + effect.getEffectType().toString());
+        }
+        if (effect != null && otherwiseEffect != null && !effect.getEffectType().equals(otherwiseEffect.getEffectType())) {
+            Assert.fail("ConditionalContinuousEffect must be same but found " + effect.getEffectType().toString() + " and " + otherwiseEffect.getEffectType().toString());
+        }
     }
 
     public ConditionalContinuousEffect(final ConditionalContinuousEffect effect) {
@@ -68,6 +78,7 @@ public class ConditionalContinuousEffect extends ContinuousEffectImpl {
 
     @Override
     public void init(Ability source, Game game) {
+        super.init(source, game);
         if (baseCondition instanceof LockedInCondition) {
             condition = new FixedCondition(((LockedInCondition) baseCondition).getBaseCondition().apply(game, source));
         } else {

Mage/src/main/java/mage/abilities/decorator/ConditionalPreventionEffect.java

@@ -0,0 +1,140 @@
+package mage.abilities.decorator;
+
+import mage.abilities.Ability;
+import mage.abilities.Mode;
+import mage.abilities.condition.Condition;
+import mage.abilities.condition.FixedCondition;
+import mage.abilities.condition.LockedInCondition;
+import mage.abilities.effects.PreventionEffect;
+import mage.abilities.effects.PreventionEffectImpl;
+import mage.constants.Duration;
+import mage.game.Game;
+import mage.game.events.GameEvent;
+
+/**
+ * @author JayDi85
+ */
+public class ConditionalPreventionEffect extends PreventionEffectImpl {
+
+    protected PreventionEffect effect;
+    protected PreventionEffect otherwiseEffect;
+    protected Condition baseCondition;
+    protected Condition condition;
+    protected boolean conditionState;
+    protected boolean initDone = false;
+
+    public ConditionalPreventionEffect(PreventionEffect effect, Condition condition, String text) {
+        this(effect, null, condition, text);
+    }
+
+    /**
+     * Only use this if both effects have the same layers
+     *
+     * @param effect
+     * @param otherwiseEffect
+     * @param condition
+     * @param text
+     */
+    public ConditionalPreventionEffect(PreventionEffect effect, PreventionEffect otherwiseEffect, Condition condition, String text) {
+        super(effect.getDuration());
+        this.effect = effect;
+        this.otherwiseEffect = otherwiseEffect;
+        this.baseCondition = condition;
+        this.staticText = text;
+    }
+
+    public ConditionalPreventionEffect(final ConditionalPreventionEffect effect) {
+        super(effect);
+        this.effect = (PreventionEffect) effect.effect.copy();
+        if (effect.otherwiseEffect != null) {
+            this.otherwiseEffect = (PreventionEffect) effect.otherwiseEffect.copy();
+        }
+        this.condition = effect.condition;  // TODO: checks conditional copy -- it's can be usefull for memory leaks fix?
+        this.conditionState = effect.conditionState;
+        this.baseCondition = effect.baseCondition;
+        this.initDone = effect.initDone;
+    }
+
+    @Override
+    public boolean isDiscarded() {
+        return this.discarded || effect.isDiscarded() || (otherwiseEffect != null && otherwiseEffect.isDiscarded());
+    }
+
+    @Override
+    public void init(Ability source, Game game) {
+        super.init(source, game);
+        if (baseCondition instanceof LockedInCondition) {
+            condition = new FixedCondition(((LockedInCondition) baseCondition).getBaseCondition().apply(game, source));
+        } else {
+            condition = baseCondition;
+        }
+        effect.setTargetPointer(this.targetPointer);
+        effect.init(source, game);
+        if (otherwiseEffect != null) {
+            otherwiseEffect.setTargetPointer(this.targetPointer);
+            otherwiseEffect.init(source, game);
+        }
+        initDone = true;
+    }
+
+    @Override
+    public boolean replaceEvent(GameEvent event, Ability source, Game game) {
+        if (conditionState) {
+            effect.setTargetPointer(this.targetPointer);
+            return effect.replaceEvent(event, source, game);
+        } else if (otherwiseEffect != null) {
+            otherwiseEffect.setTargetPointer(this.targetPointer);
+            return otherwiseEffect.replaceEvent(event, source, game);
+        }
+
+        if (!conditionState && effect.getDuration() == Duration.OneUse) {
+            used = true;
+        }
+        if (!conditionState && effect.getDuration() == Duration.Custom) {
+            this.discard();
+        }
+
+        return false;
+    }
+
+    @Override
+    public boolean apply(Game game, Ability source) {
+        return false;
+    }
+
+    @Override
+    public boolean checksEventType(GameEvent event, Game game) {
+        return effect.checksEventType(event, game)
+                || (otherwiseEffect != null && otherwiseEffect.checksEventType(event, game));
+    }
+
+    @Override
+    public boolean applies(GameEvent event, Ability source, Game game) {
+        if (!initDone) { // if simpleStaticAbility, init won't be called
+            init(source, game);
+        }
+        conditionState = condition.apply(game, source);
+        if (conditionState) {
+            effect.setTargetPointer(this.targetPointer);
+            return effect.applies(event, source, game);
+        } else if (otherwiseEffect != null) {
+            otherwiseEffect.setTargetPointer(this.targetPointer);
+            return otherwiseEffect.applies(event, source, game);
+        }
+        return false;
+    }
+
+    @Override
+    public String getText(Mode mode) {
+        if ((staticText == null || staticText.isEmpty()) && this.effect != null) { // usefull for conditional night/day card abilities
+            return effect.getText(mode);
+        }
+        return staticText;
+    }
+
+    @Override
+    public ConditionalPreventionEffect copy() {
+        return new ConditionalPreventionEffect(this);
+    }
+
+}

Mage/src/main/java/mage/abilities/effects/ContinuousEffectImpl.java

@@ -311,14 +311,6 @@ public abstract class ContinuousEffectImpl extends EffectImpl implements Continu
             }
         }
         return dependentToEffects;
-        /*
-            return allEffectsInLayer.stream()
-                    .filter(effect -> effect.getDependencyTypes().contains(dependendToTypes))
-                    .map(Effect::getId)
-                    .collect(Collectors.toSet());
-
-        }
-        return new HashSet<>();*/
     }
 
     @Override

Mage/src/main/java/mage/abilities/effects/ContinuousEffects.java

@@ -369,6 +369,7 @@ public class ContinuousEffects implements Serializable {
                 replaceEffects.put(effect, applicableAbilities);
             }
         }
+
         for (Iterator<PreventionEffect> iterator = preventionEffects.iterator(); iterator.hasNext(); ) {
             PreventionEffect effect = iterator.next();
             if (!effect.checksEventType(event, game)) {
@@ -394,6 +395,7 @@ public class ContinuousEffects implements Serializable {
                 replaceEffects.put(effect, applicableAbilities);
             }
         }
+
         return replaceEffects;
     }