From 2ecb415b4db19b9918604e0525d52ef343d9533c Mon Sep 17 00:00:00 2001 From: Nathaniel Brandes Date: Wed, 8 Mar 2017 21:41:57 -0800 Subject: [PATCH] Removed potential integer overflow. If the number passed into max is Integer.MAX_VALUE, like it is with ChoiceOfDamnation, the random number will overflow. So let's not do that. --- .../src/main/java/mage/player/ai/ComputerPlayer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Mage.Server.Plugins/Mage.Player.AI/src/main/java/mage/player/ai/ComputerPlayer.java b/Mage.Server.Plugins/Mage.Player.AI/src/main/java/mage/player/ai/ComputerPlayer.java index de54f2db07d..b33381c4356 100644 --- a/Mage.Server.Plugins/Mage.Player.AI/src/main/java/mage/player/ai/ComputerPlayer.java +++ b/Mage.Server.Plugins/Mage.Player.AI/src/main/java/mage/player/ai/ComputerPlayer.java @@ -1543,7 +1543,7 @@ public class ComputerPlayer extends PlayerImpl implements Player { } //TODO: improve this if (min < max && min == 0) { - return RandomUtil.nextInt(max + 1); + return RandomUtil.nextInt(max); } return min; }