From 26a95eed518943ee863807430b2c4d0550c16994 Mon Sep 17 00:00:00 2001 From: xenohedron Date: Sat, 20 May 2023 23:56:49 -0400 Subject: [PATCH] More sensible parameter ordering --- Mage.Sets/src/mage/cards/c/ChimericMass.java | 2 +- Mage.Sets/src/mage/cards/c/ChromiumTheMutable.java | 2 +- .../src/mage/cards/m/MonumentToPerfection.java | 2 +- .../src/mage/cards/s/SvogthosTheRestlessTomb.java | 2 +- .../continuous/BecomesCreatureSourceEffect.java | 14 +++++++------- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Mage.Sets/src/mage/cards/c/ChimericMass.java b/Mage.Sets/src/mage/cards/c/ChimericMass.java index 34b310a3908..0e7b35ee365 100644 --- a/Mage.Sets/src/mage/cards/c/ChimericMass.java +++ b/Mage.Sets/src/mage/cards/c/ChimericMass.java @@ -38,7 +38,7 @@ public final class ChimericMass extends CardImpl { .withType(CardType.ARTIFACT) .withSubType(SubType.CONSTRUCT) .withAbility(new SimpleStaticAbility(Zone.BATTLEFIELD, new SetBasePowerToughnessSourceEffect(new CountersSourceCount(CounterType.CHARGE)))), - "", Duration.EndOfTurn, false, true, false), new GenericManaCost(1))); + "", Duration.EndOfTurn, false, false, true), new GenericManaCost(1))); } private ChimericMass(final ChimericMass card) { diff --git a/Mage.Sets/src/mage/cards/c/ChromiumTheMutable.java b/Mage.Sets/src/mage/cards/c/ChromiumTheMutable.java index 18003fb81f9..115ebbbdbcc 100644 --- a/Mage.Sets/src/mage/cards/c/ChromiumTheMutable.java +++ b/Mage.Sets/src/mage/cards/c/ChromiumTheMutable.java @@ -47,7 +47,7 @@ public final class ChromiumTheMutable extends CardImpl { Ability ability = new SimpleActivatedAbility( new BecomesCreatureSourceEffect( new ChromiumTheMutableToken(), null, Duration.EndOfTurn, - false, false, true + false, true, false ).setText("Until end of turn, {this} becomes " + "a Human with base power and toughness 1/1, " + "loses all abilities, and gains hexproof"), diff --git a/Mage.Sets/src/mage/cards/m/MonumentToPerfection.java b/Mage.Sets/src/mage/cards/m/MonumentToPerfection.java index 8646abfdff3..8f7671c8ce7 100644 --- a/Mage.Sets/src/mage/cards/m/MonumentToPerfection.java +++ b/Mage.Sets/src/mage/cards/m/MonumentToPerfection.java @@ -63,7 +63,7 @@ public final class MonumentToPerfection extends CardImpl { .withAbility(IndestructibleAbility.getInstance()) .withAbility(new ToxicAbility(9)), null, Duration.Custom, true, - false, true + true, false ), new GenericManaCost(3), MonumentToPerfectionCondition.instance ).addHint(MonumentToPerfectionValue.getHint())); } diff --git a/Mage.Sets/src/mage/cards/s/SvogthosTheRestlessTomb.java b/Mage.Sets/src/mage/cards/s/SvogthosTheRestlessTomb.java index 36c0efe8a42..26db4e438ee 100644 --- a/Mage.Sets/src/mage/cards/s/SvogthosTheRestlessTomb.java +++ b/Mage.Sets/src/mage/cards/s/SvogthosTheRestlessTomb.java @@ -33,7 +33,7 @@ public final class SvogthosTheRestlessTomb extends CardImpl { this.addAbility(new ColorlessManaAbility()); // {3}{B}{G}: Until end of turn, Svogthos, the Restless Tomb becomes a black and green Plant Zombie creature with "This creature's power and toughness are each equal to the number of creature cards in your graveyard." It's still a land. // set to character defining to prevent setting P/T again to 0 becuase already set by CDA of the token - Ability ability = new SimpleActivatedAbility(Zone.BATTLEFIELD, new BecomesCreatureSourceEffect(new SvogthosToken(), "land", Duration.EndOfTurn, false, true, false), new ManaCostsImpl<>("{3}{B}{G}")); + Ability ability = new SimpleActivatedAbility(Zone.BATTLEFIELD, new BecomesCreatureSourceEffect(new SvogthosToken(), "land", Duration.EndOfTurn, false, false, true), new ManaCostsImpl<>("{3}{B}{G}")); this.addAbility(ability); } diff --git a/Mage/src/main/java/mage/abilities/effects/common/continuous/BecomesCreatureSourceEffect.java b/Mage/src/main/java/mage/abilities/effects/common/continuous/BecomesCreatureSourceEffect.java index 68a9341273a..a9c1786dfea 100644 --- a/Mage/src/main/java/mage/abilities/effects/common/continuous/BecomesCreatureSourceEffect.java +++ b/Mage/src/main/java/mage/abilities/effects/common/continuous/BecomesCreatureSourceEffect.java @@ -42,14 +42,14 @@ public class BecomesCreatureSourceEffect extends ContinuousEffectImpl implements } /** - @param token Token as blueprint for creature to become - @param theyAreStillType String for rules text generation - @param duration Duration for the effect - @param losePreviousTypes if true, permanent loses its previous types - @param characterDefining if true, effect applies on layer 7a (it probably shouldn't) - @param loseAbilities if true, permanent loses its other abilities + * @param token Token as blueprint for creature to become + * @param theyAreStillType String for rules text generation + * @param duration Duration for the effect + * @param losePreviousTypes if true, permanent loses its previous types + * @param loseAbilities if true, permanent loses its other abilities + * @param characterDefining if true, effect applies on layer 7a (it probably shouldn't) */ - public BecomesCreatureSourceEffect(Token token, String theyAreStillType, Duration duration, boolean losePreviousTypes, boolean characterDefining, boolean loseAbilities) { + public BecomesCreatureSourceEffect(Token token, String theyAreStillType, Duration duration, boolean losePreviousTypes, boolean loseAbilities, boolean characterDefining) { super(duration, Outcome.BecomeCreature); this.characterDefining = characterDefining; this.token = token;