External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-20 02:30:08 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge 23bf1ae03c into acc180d1d4

Browse source
This commit is contained in:
ssk97 2025-12-16 15:37:14 -06:00 • committed by GitHub
commit 1d6bede017
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -2573,7 +2573,7 @@ public class VerifyCardDataTest {
} }
} }
private static final String[] wrongSymbols = {"’", "“", "”"}; private static final String[] wrongSymbols = {"’", "“", "”", "\n"};
private void checkWrongSymbolsInRules(Card card) { private void checkWrongSymbolsInRules(Card card) {
for (String s : wrongSymbols) { for (String s : wrongSymbols) {
@ -2582,6 +2582,10 @@ public class VerifyCardDataTest {
} }
} }
Pattern ruleNameCheck = Pattern.compile("\\b(?<!named |name is )"+Pattern.quote(card.getName())+"(?! \\{)");
Set<String> overlapNames = Arrays.stream(SubType.class.getEnumConstants()).map(SubType::toString).collect(Collectors.toSet()); // Assembly-Worker, Coward, etc.
// TODO: Tibalt, Cosmic Impostor's emblem should refer to the source permanent, even if it has a different name
overlapNames.addAll(Arrays.asList("Exile", "Kher Keep", "Kookus", "Regenerate", "Shield of Kaldra", "Stangg", "Tibalt, Cosmic Impostor"));
for (String rule : card.getRules()) { for (String rule : card.getRules()) {
for (String s : wrongSymbols) { for (String s : wrongSymbols) {
if (rule.contains(s)) { if (rule.contains(s)) {
@ -2591,6 +2595,12 @@ public class VerifyCardDataTest {
if (rule.contains("&mdash ")) { if (rule.contains("&mdash ")) {
fail(card, "rules", "card's rules contains restricted test [&mdash ] instead [&mdash;]"); fail(card, "rules", "card's rules contains restricted test [&mdash ] instead [&mdash;]");
} }
if (ruleNameCheck.matcher(rule).find() && !overlapNames.contains(card.getName())) {
fail(card, "rules", "card's pre-formatted rules incorrectly contains its name directly, probably use {this} instead or add to overlapNames exceptions list");
}
if (rule.contains("named {this}") || rule.contains("name is {this}")) {
fail(card, "rules", "card's rules contains \"named {this}\" or \"name is {this}\", should use card's name directly");
}
} }
} }