External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-22 03:22:00 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed Dark Impostor not properly gaining abilities (fixes #4938)

Browse source
This commit is contained in:
Evan Kranzler 2018-05-19 18:13:51 -04:00
parent 01fb64367e
commit 1720b17ebe
3 changed files with 47 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

47
Mage.Sets/src/mage/cards/d/DarkImpostor.java
View file

@ -29,14 +29,15 @@ package mage.cards.d;
import java.util.UUID; import java.util.UUID;
import mage.MageInt; import mage.MageInt;
import mage.MageObject;
import mage.abilities.Ability; import mage.abilities.Ability;
import mage.abilities.ActivatedAbility; import mage.abilities.ActivatedAbility;
import mage.abilities.Mode;
import mage.abilities.common.SimpleActivatedAbility; import mage.abilities.common.SimpleActivatedAbility;
import mage.abilities.common.SimpleStaticAbility; import mage.abilities.common.SimpleStaticAbility;
import mage.abilities.costs.mana.ManaCostsImpl; import mage.abilities.costs.mana.ManaCostsImpl;
import mage.abilities.effects.ContinuousEffectImpl; import mage.abilities.effects.ContinuousEffectImpl;
import mage.abilities.effects.common.ExileTargetEffect; import mage.abilities.effects.OneShotEffect;
import mage.abilities.effects.common.ImprintTargetEffect;
import mage.abilities.effects.common.counter.AddCountersSourceEffect; import mage.abilities.effects.common.counter.AddCountersSourceEffect;
import mage.cards.Card; import mage.cards.Card;
import mage.cards.CardImpl; import mage.cards.CardImpl;
@ -62,10 +63,8 @@ public class DarkImpostor extends CardImpl {
this.power = new MageInt(2); this.power = new MageInt(2);
this.toughness = new MageInt(2); this.toughness = new MageInt(2);
// {4}{B}{B}: Exile target creature and put a +1/+1 counter on Dark Impostor.\ // {4}{B}{B}: Exile target creature and put a +1/+1 counter on Dark Impostor.
Ability ability = new SimpleActivatedAbility(Zone.BATTLEFIELD, new ImprintTargetEffect(), new ManaCostsImpl("{4}{B}{B}")); Ability ability = new SimpleActivatedAbility(Zone.BATTLEFIELD, new DarkImpostorExileTargetEffect(), new ManaCostsImpl("{4}{B}{B}"));
ability.addEffect(new ExileTargetEffect(null, this.getIdName()));
ability.addEffect(new AddCountersSourceEffect(CounterType.P1P1.createInstance()));
ability.addTarget(new TargetCreaturePermanent()); ability.addTarget(new TargetCreaturePermanent());
this.addAbility(ability); this.addAbility(ability);
@ -83,6 +82,40 @@ public class DarkImpostor extends CardImpl {
} }
} }
class DarkImpostorExileTargetEffect extends OneShotEffect {
public DarkImpostorExileTargetEffect() {
super(Outcome.Exile);
}
public DarkImpostorExileTargetEffect(final DarkImpostorExileTargetEffect effect) {
super(effect);
}
@Override
public DarkImpostorExileTargetEffect copy() {
return new DarkImpostorExileTargetEffect(this);
}
@Override
public boolean apply(Game game, Ability source) {
Permanent permanent = game.getPermanentOrLKIBattlefield(source.getFirstTarget());
MageObject sourceObject = source.getSourceObject(game);
if (permanent != null) {
permanent.moveToExile(null, null, source.getSourceId(), game);
if (sourceObject instanceof Permanent) {
((Permanent) sourceObject).imprint(permanent.getId(), game);
}
}
return new AddCountersSourceEffect(CounterType.P1P1.createInstance()).apply(game, source);
}
@Override
public String getText(Mode mode) {
return "exile target creature and put a +1/+1 counter on {this}";
}
}
class DarkImpostorContinuousEffect extends ContinuousEffectImpl { class DarkImpostorContinuousEffect extends ContinuousEffectImpl {
public DarkImpostorContinuousEffect() { public DarkImpostorContinuousEffect() {
@ -103,7 +136,7 @@ class DarkImpostorContinuousEffect extends ContinuousEffectImpl {
if (card != null) { if (card != null) {
for (Ability ability : card.getAbilities()) { for (Ability ability : card.getAbilities()) {
if (ability instanceof ActivatedAbility) { if (ability instanceof ActivatedAbility) {
perm.addAbility(ability, source.getSourceId(), game); perm.addAbility(ability.copy(), source.getSourceId(), game);
} }
} }
} }

5
Mage.Sets/src/mage/cards/m/MairsilThePretender.java
View file

@ -32,7 +32,6 @@ import java.util.UUID;
import mage.MageInt; import mage.MageInt;
import mage.abilities.Ability; import mage.abilities.Ability;
import mage.abilities.ActivatedAbility; import mage.abilities.ActivatedAbility;
import mage.abilities.ActivatedAbilityImpl;
import mage.abilities.common.EntersBattlefieldTriggeredAbility; import mage.abilities.common.EntersBattlefieldTriggeredAbility;
import mage.abilities.common.SimpleStaticAbility; import mage.abilities.common.SimpleStaticAbility;
import mage.abilities.effects.ContinuousEffectImpl; import mage.abilities.effects.ContinuousEffectImpl;
@ -169,9 +168,9 @@ class MairsilThePretenderGainAbilitiesEffect extends ContinuousEffectImpl {
if (filter.match(card, game) && Objects.equals(card.getOwnerId(), perm.getControllerId())) { if (filter.match(card, game) && Objects.equals(card.getOwnerId(), perm.getControllerId())) {
for (Ability ability : card.getAbilities()) { for (Ability ability : card.getAbilities()) {
if (ability instanceof ActivatedAbility) { if (ability instanceof ActivatedAbility) {
ActivatedAbilityImpl copyAbility = (ActivatedAbilityImpl) ability.copy(); ActivatedAbility copyAbility = (ActivatedAbility) ability.copy();
copyAbility.setMaxActivationsPerTurn(1); copyAbility.setMaxActivationsPerTurn(1);
perm.addAbility(copyAbility, card.getId(), game); perm.addAbility(copyAbility, source.getSourceId(), game);
} }
} }
} }

4
Mage/src/main/java/mage/abilities/ActivatedAbility.java
View file

@ -67,4 +67,8 @@ public interface ActivatedAbility extends Ability {
void setCheckPlayableMode(); void setCheckPlayableMode();
boolean isCheckPlayableMode(); boolean isCheckPlayableMode();
void setMaxActivationsPerTurn(int maxActivationsPerTurn);
int getMaxActivationsPerTurn(Game game);
} }