External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-20 10:40:06 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix Xanathar, Guild Kingpin (#12133)

Browse source 
fix #12133
This commit is contained in:
Susucre 2024-04-17 19:59:31 +02:00
parent 92b722d3ca
commit 11373fd75d
3 changed files with 39 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Mage.Sets/src/mage/cards/x/XanatharGuildKingpin.java
View file

@ -163,12 +163,19 @@ class XanatharPlayFromTopOfTargetLibraryEffect extends AsThoughEffectImpl {
@Override @Override
public boolean applies(UUID objectId, Ability affectedAbility, Ability source, Game game, UUID playerId) { public boolean applies(UUID objectId, Ability affectedAbility, Ability source, Game game, UUID playerId) {
if (!(affectedAbility instanceof SpellAbility) || !playerId.equals(source.getControllerId())) { Card cardToCheck = game.getCard(objectId);
if (cardToCheck == null) {
return false; return false;
} }
SpellAbility spell = (SpellAbility) affectedAbility; if (affectedAbility instanceof SpellAbility) {
Card cardToCheck = spell.getCharacteristics(game); SpellAbility spell = (SpellAbility) affectedAbility;
if (spell.getManaCosts().isEmpty()) { cardToCheck = spell.getCharacteristics(game);
if (spell.getManaCosts().isEmpty()) {
return false; // prevent casting cards without mana cost?
}
}
// only permits you to cast
if (!playerId.equals(source.getControllerId())) {
return false; return false;
} }
Player controller = game.getPlayer(source.getControllerId()); Player controller = game.getPlayer(source.getControllerId());
@ -176,7 +183,7 @@ class XanatharPlayFromTopOfTargetLibraryEffect extends AsThoughEffectImpl {
if (controller == null || opponent == null) { if (controller == null || opponent == null) {
return false; return false;
} }
// main card of spell must be on top of the opponent's library // main card of spell/land must be on top of the opponent's library
Card topCard = opponent.getLibrary().getFromTop(game); Card topCard = opponent.getLibrary().getFromTop(game);
return topCard != null && topCard.getId().equals(cardToCheck.getMainCard().getId()); return topCard != null && topCard.getId().equals(cardToCheck.getMainCard().getId());
} }

24
Mage.Tests/src/test/java/org/mage/test/cards/single/afr/XanatharGuildKingpinTest.java
View file

@ -57,4 +57,28 @@ public class XanatharGuildKingpinTest extends CardTestPlayerBase {
setStopAt(2, PhaseStep.END_TURN); setStopAt(2, PhaseStep.END_TURN);
execute(); execute();
} }
@Test
public void test_PlayLand() {
setStrictChooseMode(true);
skipInitShuffling();
// At the beginning of your upkeep, choose target opponent.
// Until end of turn, that player can’t cast spells, you may look at the top card of their library any time,
// you may play the top card of their library, and you may spend mana as though it were mana of any color
// to cast spells this way.
addCard(Zone.BATTLEFIELD, playerA, "Xanathar, Guild Kingpin");
addCard(Zone.LIBRARY, playerB, "Taiga");
// activate on opponent
addTarget(playerA, playerB);
// play from B
playLand(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Taiga");
setStopAt(1, PhaseStep.BEGIN_COMBAT);
execute();
assertPermanentCount(playerA, "Taiga", 1);
}
} }

6
Mage/src/main/java/mage/abilities/effects/common/continuous/PlayFromTopOfLibraryEffect.java
View file

@ -68,15 +68,15 @@ public class PlayFromTopOfLibraryEffect extends AsThoughEffectImpl {
public boolean applies(UUID objectId, Ability affectedAbility, Ability source, Game game, UUID playerId) { public boolean applies(UUID objectId, Ability affectedAbility, Ability source, Game game, UUID playerId) {
// can play lands/spells (must check specific part and allows specific part) // can play lands/spells (must check specific part and allows specific part)
Card cardToCheck = game.getCard(objectId); // maybe this should be removed and only check SpellAbility characteristics Card cardToCheck = game.getCard(objectId); // maybe this should be removed and only check SpellAbility characteristics -- No! don't forget PlayLandAbility
if (cardToCheck == null) { if (cardToCheck == null) {
return false; return false;
} }
if (affectedAbility instanceof SpellAbility) { if (affectedAbility instanceof SpellAbility) {
SpellAbility spell = (SpellAbility) affectedAbility; SpellAbility spell = (SpellAbility) affectedAbility;
cardToCheck = spell.getCharacteristics(game); cardToCheck = spell.getCharacteristics(game);
if (spell.getManaCosts().isEmpty()){ if (spell.getManaCosts().isEmpty()) {
return false; return false; // prevent casting cards without mana cost?
} }
} }
// only permits you to cast // only permits you to cast