External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-23 12:02:01 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Tests:

Browse source 
* added new checks for basic land types/rarity in mage-verify;
 * fixed tests for UGL cards in mage-verify (wrong json data)
This commit is contained in:
Oleg Agafonov 2018-01-11 20:37:38 +04:00
parent ab4490e476
commit 0ba2375ac1
1 changed files with 59 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

61
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -4,6 +4,8 @@ import mage.ObjectColor;
import mage.cards.*; import mage.cards.*;
import mage.cards.basiclands.BasicLand; import mage.cards.basiclands.BasicLand;
import mage.constants.CardType; import mage.constants.CardType;
import mage.constants.Rarity;
import mage.constants.SuperType;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Test; import org.junit.Test;
@ -30,6 +32,12 @@ public class VerifyCardDataTest {
static { static {
// skip lists for checks (example: unstable cards with same name may have different stats) // skip lists for checks (example: unstable cards with same name may have different stats)
// TODO: mtgjson have wrong data for UGL
// remove after fixed
// https://github.com/mtgjson/mtgjson/issues/531
// https://github.com/mtgjson/mtgjson/issues/534
// https://github.com/mtgjson/mtgjson/issues/535
// power-toughness // power-toughness
skipListCreate("PT"); skipListCreate("PT");
skipListAddName("PT", "Garbage Elemental"); // UST skipListAddName("PT", "Garbage Elemental"); // UST
@ -37,19 +45,25 @@ public class VerifyCardDataTest {
// color // color
skipListCreate("COLOR"); skipListCreate("COLOR");
//skipListAddName("COLOR", "Ulrich, Uncontested Alpha"); // gatherer is missing the color indicator on one card and json has wrong data (16.12.2017: not actual)
// cost // cost
skipListCreate("COST"); skipListCreate("COST");
// supertype // supertype
skipListCreate("SUPERTYPE"); skipListCreate("SUPERTYPE");
skipListAddName("SUPERTYPE", "Timmy, Power Gamer"); // UGL, mtgjson error
// type // type
skipListCreate("TYPE"); skipListCreate("TYPE");
skipListAddName("TYPE", "Fowl Play"); // UGL, mtgjson error
// subtype // subtype
skipListCreate("SUBTYPE"); skipListCreate("SUBTYPE");
skipListAddName("SUBTYPE", "Timmy, Power Gamer"); // UGL, mtgjson error
skipListAddName("SUBTYPE", "Fowl Play"); // UGL, mtgjson error
skipListAddName("SUBTYPE", "Paper Tiger"); // UGL, mtgjson error
skipListAddName("SUBTYPE", "Rock Lobster"); // UGL, mtgjson error
skipListAddName("SUBTYPE", "Scissors Lizard"); // UGL, mtgjson error
// number // number
skipListCreate("NUMBER"); skipListCreate("NUMBER");
@ -76,7 +90,7 @@ public class VerifyCardDataTest {
private void fail(Card card, String category, String message) { private void fail(Card card, String category, String message) {
failed++; failed++;
System.out.println("Error: (" + category + ") " + message + " for " + card.getName()); System.out.println("Error: (" + category + ") " + message + " for " + card.getName() + " (" + card.getExpansionSetCode() + ")");
} }
private int failed = 0; private int failed = 0;
@ -280,6 +294,7 @@ public class VerifyCardDataTest {
checkTypes(card, ref); checkTypes(card, ref);
checkColors(card, ref); checkColors(card, ref);
//checkNumbers(card, ref); // TODO: load data from allsets.json and check it (allcards.json do not have card numbers) //checkNumbers(card, ref); // TODO: load data from allsets.json and check it (allcards.json do not have card numbers)
checkBasicLands(card, ref);
} }
private void checkColors(Card card, JsonCard ref) { private void checkColors(Card card, JsonCard ref) {
@ -393,6 +408,48 @@ public class VerifyCardDataTest {
} }
} }
private boolean isBasicLandName(String name) {
String checkName = name;
if (name.startsWith("Snow-Covered ")) {
// snow lands is basic lands too
checkName = name.replace("Snow-Covered ", "");
}
return checkName.equals("Island") ||
checkName.equals("Forest") ||
checkName.equals("Swamp") ||
checkName.equals("Plains") ||
checkName.equals("Mountain") ||
checkName.equals("Wastes");
}
private void checkBasicLands(Card card, JsonCard ref) {
// basic lands must have Rarity.LAND and SuperType.BASIC
// other cards can't have that stats
if (isBasicLandName(card.getName())) {
// lands
if (card.getRarity() != Rarity.LAND) {
fail(card, "rarity", "basic land must be Rarity.LAND");
}
if (!card.getSuperType().contains(SuperType.BASIC)) {
fail(card, "supertype", "basic land must be SuperType.BASIC");
}
} else {
// non lands
if (card.getRarity() == Rarity.LAND) {
fail(card, "rarity", "only basic land can be Rarity.LAND");
}
if (card.getSuperType().contains(SuperType.BASIC)) {
fail(card, "supertype", "only basic land can be SuperType.BASIC");
}
}
}
private String join(Iterable<?> items) { private String join(Iterable<?> items) {
StringBuilder result = new StringBuilder(); StringBuilder result = new StringBuilder();
for (Object item : items) { for (Object item : items) {