From 0ae339ff26b1ccbec887f5af9a9fd7114e5284fe Mon Sep 17 00:00:00 2001 From: LevelX2 Date: Fri, 1 May 2015 11:09:57 +0200 Subject: [PATCH] * Hive Mind - Working again if copied spell is not countered. Added some tests for Hive Mind (#717). --- .../src/mage/sets/magic2010/HiveMind.java | 35 ++++--- .../mage/sets/mirrodin/ChaliceOfTheVoid.java | 19 ++-- .../mage/test/cards/copy/HiveMindTest.java | 98 +++++++++++++++++++ 3 files changed, 128 insertions(+), 24 deletions(-) create mode 100644 Mage.Tests/src/test/java/org/mage/test/cards/copy/HiveMindTest.java diff --git a/Mage.Sets/src/mage/sets/magic2010/HiveMind.java b/Mage.Sets/src/mage/sets/magic2010/HiveMind.java index 4596e6d9a7c..b33a3c8e8a2 100644 --- a/Mage.Sets/src/mage/sets/magic2010/HiveMind.java +++ b/Mage.Sets/src/mage/sets/magic2010/HiveMind.java @@ -55,8 +55,6 @@ public class HiveMind extends CardImpl { super(ownerId, 54, "Hive Mind", Rarity.RARE, new CardType[]{CardType.ENCHANTMENT}, "{5}{U}"); this.expansionSetCode = "M10"; - this.color.setBlue(true); - // Whenever a player casts an instant or sorcery spell, each other player copies that spell. Each of those players may choose new targets for his or her copy. this.addAbility(new HiveMindTriggeredAbility()); } @@ -86,19 +84,22 @@ class HiveMindTriggeredAbility extends TriggeredAbilityImpl { return new HiveMindTriggeredAbility(this); } + @Override + public boolean checkEventType(GameEvent event, Game game) { + return event.getType() == GameEvent.EventType.SPELL_CAST; + } + @Override public boolean checkTrigger(GameEvent event, Game game) { - if (event.getType() == GameEvent.EventType.SPELL_CAST) { - Spell spell = game.getStack().getSpell(event.getTargetId()); - if (spell != null && (spell.getCardType().contains(CardType.INSTANT) - || spell.getCardType().contains(CardType.SORCERY))) { - for(Effect effect : getEffects()) { - if(effect instanceof HiveMindEffect) { - ((HiveMindEffect)effect).setTargetPointer(new FixedTarget(spell.getId())); - } - } - return true; + Spell spell = game.getStack().getSpell(event.getTargetId()); + if (spell != null && (spell.getCardType().contains(CardType.INSTANT) + || spell.getCardType().contains(CardType.SORCERY))) { + for (Effect effect : getEffects()) { + if (effect instanceof HiveMindEffect) { + ((HiveMindEffect) effect).setTargetPointer(new FixedTarget(spell.getId())); + } } + return true; } return false; } @@ -110,8 +111,6 @@ class HiveMindTriggeredAbility extends TriggeredAbilityImpl { } class HiveMindEffect extends OneShotEffect { - - private Spell _spell; public HiveMindEffect() { super(Outcome.Benefit); @@ -126,10 +125,14 @@ class HiveMindEffect extends OneShotEffect { public HiveMindEffect copy() { return new HiveMindEffect(this); } - + @Override public boolean apply(Game game, Ability source) { - Spell spell = (Spell) game.getLastKnownInformation(((FixedTarget) getTargetPointer()).getTarget(), Zone.STACK); + Spell spell; + spell = game.getStack().getSpell(((FixedTarget) getTargetPointer()).getTarget()); + if (spell == null) { // if spell e.g. was countered + spell = (Spell) game.getLastKnownInformation(((FixedTarget) getTargetPointer()).getTarget(), Zone.STACK); + } Player player = game.getPlayer(source.getControllerId()); if (spell != null && player != null) { Set players = player.getInRange(); diff --git a/Mage.Sets/src/mage/sets/mirrodin/ChaliceOfTheVoid.java b/Mage.Sets/src/mage/sets/mirrodin/ChaliceOfTheVoid.java index edabcd92e5c..92255a1111e 100644 --- a/Mage.Sets/src/mage/sets/mirrodin/ChaliceOfTheVoid.java +++ b/Mage.Sets/src/mage/sets/mirrodin/ChaliceOfTheVoid.java @@ -124,17 +124,20 @@ class ChaliceOfTheVoidTriggeredAbility extends TriggeredAbilityImpl { return new ChaliceOfTheVoidTriggeredAbility(this); } + @Override + public boolean checkEventType(GameEvent event, Game game) { + return event.getType() == GameEvent.EventType.SPELL_CAST; + } + @Override public boolean checkTrigger(GameEvent event, Game game) { - if(event.getType() == GameEvent.EventType.SPELL_CAST){ - Permanent chalice = game.getPermanent(this.sourceId); - Spell spell = game.getStack().getSpell(event.getTargetId()); - if(spell != null && chalice != null && spell.getConvertedManaCost() == chalice.getCounters().getCount(CounterType.CHARGE)){ - for (Effect effect : this.getEffects()) { - effect.setTargetPointer(new FixedTarget(event.getTargetId())); - } - return true; + Permanent chalice = game.getPermanent(getSourceId()); + Spell spell = game.getStack().getSpell(event.getTargetId()); + if(spell != null && chalice != null && spell.getConvertedManaCost() == chalice.getCounters().getCount(CounterType.CHARGE)){ + for (Effect effect : this.getEffects()) { + effect.setTargetPointer(new FixedTarget(event.getTargetId())); } + return true; } return false; } diff --git a/Mage.Tests/src/test/java/org/mage/test/cards/copy/HiveMindTest.java b/Mage.Tests/src/test/java/org/mage/test/cards/copy/HiveMindTest.java new file mode 100644 index 00000000000..2e376e406cc --- /dev/null +++ b/Mage.Tests/src/test/java/org/mage/test/cards/copy/HiveMindTest.java @@ -0,0 +1,98 @@ +/* + * Copyright 2010 BetaSteward_at_googlemail.com. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without modification, are + * permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this list of + * conditions and the following disclaimer. + * + * 2. Redistributions in binary form must reproduce the above copyright notice, this list + * of conditions and the following disclaimer in the documentation and/or other materials + * provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY BetaSteward_at_googlemail.com ``AS IS'' AND ANY EXPRESS OR IMPLIED + * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND + * FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL BetaSteward_at_googlemail.com OR + * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING + * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF + * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + * + * The views and conclusions contained in the software and documentation are those of the + * authors and should not be interpreted as representing official policies, either expressed + * or implied, of BetaSteward_at_googlemail.com. + */ +package org.mage.test.cards.copy; + + +import mage.constants.PhaseStep; +import mage.constants.Zone; +import org.junit.Assert; +import org.junit.Test; +import org.mage.test.serverside.base.CardTestPlayerBase; + +/** + * + * @author LevelX2 + */ +public class HiveMindTest extends CardTestPlayerBase { + + /** + * Check that opponent gets a copy of Lightning Bolt + */ + @Test + public void testTransform() { + addCard(Zone.BATTLEFIELD, playerA, "Mountain", 1); + // Whenever a player casts an instant or sorcery spell, each other player copies that spell. + // Each of those players may choose new targets for his or her copy. + addCard(Zone.BATTLEFIELD, playerA, "Hive Mind", 1); + addCard(Zone.HAND, playerA, "Lightning Bolt", 1); + setChoice(playerB, "Yes"); + addTarget(playerB, playerA); + + castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Lightning Bolt", playerB); + setStopAt(1, PhaseStep.BEGIN_COMBAT); + execute(); + + assertLife(playerB, 17); + assertLife(playerA, 17); + } + + /** + * The Amulet Bloom deck in Modern has a few wincons, one of them being that the Bloom player + * resolves a Hive Mind, then casts a Pact. The Hive Mind copies it so the opponent also casts a Pact. + * If the opposing player has a Chalice set on ZERO, it will counter both copies which it should + * NOT DO because Hive Mind puts a copy onto the stack, not 'cast'. So while the Bloom player's + * copy is countered, the opponent will still cast and have to pay during their upkeep. + */ + @Test + public void testChaliceOfTtheVoid() { + // Whenever a player casts an instant or sorcery spell, each other player copies that spell. + // Each of those players may choose new targets for his or her copy. + addCard(Zone.BATTLEFIELD, playerA, "Hive Mind", 1); + // Put a 4/4 red Giant creature token onto the battlefield. + // At the beginning of your next upkeep, pay {4}{R}. If you don't, you lose the game. + addCard(Zone.HAND, playerA, "Pact of the Titan", 1); + // Chalice of the Void enters the battlefield with X charge counters on it. + // Whenever a player casts a spell with converted mana cost equal to the number of charge counters on Chalice of the Void, counter that spell. + addCard(Zone.BATTLEFIELD, playerB, "Chalice of the Void", 1); + + setChoice(playerB, "Yes"); + + castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Pact of the Titan"); + + setStopAt(2, PhaseStep.PRECOMBAT_MAIN); + execute(); + + assertGraveyardCount(playerA, "Pact of the Titan", 1); + assertPermanentCount(playerA, "Giant", 0); // was countered by Chalice + assertPermanentCount(playerB, "Giant", 1); // was not countered by Chalice because it was not cast + Assert.assertTrue("Player A must have won", playerA.hasWon()); + Assert.assertTrue("Player B must have lost", playerB.hasLost()); + assertLife(playerB, 20); + assertLife(playerA, 20); + } +} \ No newline at end of file