From b2a809ebd859c85c37d6229f5d5670474e3bda51 Mon Sep 17 00:00:00 2001 From: Ola Bini Date: Fri, 20 Dec 2019 16:19:06 +0000 Subject: [PATCH] Don't try to close the TCP listener, since it was already closed when the TLS listener was closed --- cmd/grumble/server.go | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/cmd/grumble/server.go b/cmd/grumble/server.go index ddf67bd..8dc0f21 100644 --- a/cmd/grumble/server.go +++ b/cmd/grumble/server.go @@ -15,9 +15,16 @@ import ( "encoding/hex" "errors" "fmt" - "github.com/golang/protobuf/proto" "hash" "log" + "net" + "net/http" + "path/filepath" + "strings" + "sync" + "time" + + "github.com/golang/protobuf/proto" "mumble.info/grumble/pkg/acl" "mumble.info/grumble/pkg/ban" "mumble.info/grumble/pkg/freezer" @@ -27,12 +34,6 @@ import ( "mumble.info/grumble/pkg/serverconf" "mumble.info/grumble/pkg/sessionpool" "mumble.info/grumble/pkg/web" - "net" - "net/http" - "path/filepath" - "strings" - "sync" - "time" ) // The default port a Murmur server listens on @@ -1452,9 +1453,9 @@ func (server *Server) Start() (err error) { // Set sensible timeouts, in case no reverse proxy is in front of Grumble. // Non-conforming (or malicious) clients may otherwise block indefinitely and cause // file descriptors (or handles, depending on your OS) to leak and/or be exhausted - ReadTimeout: 5 * time.Second, + ReadTimeout: 5 * time.Second, WriteTimeout: 10 * time.Second, - IdleTimeout: 2 * time.Minute, + IdleTimeout: 2 * time.Minute, } go func() { err := server.webhttp.ListenAndServeTLS("", "") @@ -1532,10 +1533,6 @@ func (server *Server) Stop() (err error) { if err != nil { return err } - err = server.tcpl.Close() - if err != nil { - return err - } err = server.webwsl.Close() if err != nil { return err