External/ergo
1
0
Fork 1
mirror of https://github.com/ergochat/ergo.git synced 2026-01-09 20:02:07 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

channel: Kill a race condition that locked up the server.

Browse source 
Specifically, if you joined a channel while someone else was trying to part. the Join method would grab the lock, the Quit method would queue to grab the lock, the Join method would unlock and then try to regrab the lock, and it would get into a situation where nobody would have the lock and everyone would be waiting for it.

This caused weird oddities with clients.
This commit is contained in:
Daniel Oaks 2017-03-26 22:11:09 +10:00
parent cec3416eae
commit 300d02bd9c
2 changed files with 12 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
irc/client.go
View file

@ -482,7 +482,7 @@ func (client *Client) destroy() {
// clean up channels
for channel := range client.channels {
channel.Quit(client)
channel.Quit(client, &friends)
}
// clean up server