From b48e2f1f1b9aa9bf247b6ce31efd1ab135cdf201 Mon Sep 17 00:00:00 2001
From: aler9 <46489434+aler9@users.noreply.github.com>
Date: Thu, 20 Jan 2022 10:46:05 +0100
Subject: [PATCH] add TODO comments

---
 internal/conf/path.go | 6 ++++--
 internal/core/api.go  | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/internal/conf/path.go b/internal/conf/path.go
index cf5c002c..abd31e97 100644
--- a/internal/conf/path.go
+++ b/internal/conf/path.go
@@ -67,10 +67,12 @@ type PathConf struct {
 	RunOnDemandCloseAfter   StringDuration `json:"runOnDemandCloseAfter"`
 	RunOnReady              string         `json:"runOnReady"`
 	RunOnReadyRestart       bool           `json:"runOnReadyRestart"`
-	RunOnPublish            string         `json:"runOnPublish"`        // deprecated, replaced by runOnReady
-	RunOnPublishRestart     bool           `json:"runOnPublishRestart"` // deprecated, replaced by runOnReadyRestart
 	RunOnRead               string         `json:"runOnRead"`
 	RunOnReadRestart        bool           `json:"runOnReadRestart"`
+
+	// deprecated, replaced by runOnReady. TODO: remove in next version
+	RunOnPublish        string `json:"runOnPublish"`
+	RunOnPublishRestart bool   `json:"runOnPublishRestart"`
 }
 
 func (pconf *PathConf) checkAndFillMissing(conf *Conf, name string) error {
diff --git a/internal/core/api.go b/internal/core/api.go
index a0c8ccda..6991f3e8 100644
--- a/internal/core/api.go
+++ b/internal/core/api.go
@@ -127,10 +127,12 @@ func loadConfPathData(ctx *gin.Context) (interface{}, error) {
 		RunOnDemandCloseAfter   *conf.StringDuration `json:"runOnDemandCloseAfter"`
 		RunOnReady              *string              `json:"runOnReady"`
 		RunOnReadyRestart       *bool                `json:"runOnReadyRestart"`
-		RunOnPublish            *string              `json:"runOnPublish"`        // deprecated, replaced by runOnReady
-		RunOnPublishRestart     *bool                `json:"runOnPublishRestart"` // deprecated, replaced by runOnReadyRestart
 		RunOnRead               *string              `json:"runOnRead"`
 		RunOnReadRestart        *bool                `json:"runOnReadRestart"`
+
+		// deprecated, replaced by runOnReady. TODO: remove in next version
+		RunOnPublish        *string `json:"runOnPublish"`
+		RunOnPublishRestart *bool   `json:"runOnPublishRestart"`
 	}
 	err := json.NewDecoder(ctx.Request.Body).Decode(&in)
 	if err != nil {