From da15744b3da2b62e94b52d5b592410ce0a94cc9a Mon Sep 17 00:00:00 2001
From: Adrian Shum <adrian@cshum.com>
Date: Thu, 13 Oct 2022 18:26:14 +0800
Subject: [PATCH] refactor(ffmpeg): process on select frame

* refactor(ffmpeg): process on select frame

* reset golden

* test: update golden files
---
 ffmpeg/ffmpeg.go                                       | 3 +++
 ffmpeg/ffmpeg_test.go                                  | 3 ---
 testdata/golden/meta/alpha-webm.webm.meta.json         | 2 +-
 testdata/golden/meta/everybody-betray-me.mkv.meta.json | 2 +-
 testdata/golden/meta/macabre.mp4.meta.json             | 2 +-
 testdata/golden/meta/schizo.flv.meta.json              | 2 +-
 testdata/golden/meta/schizo_0.mp4.meta.json            | 2 +-
 testdata/golden/meta/schizo_180.mp4.meta.json          | 2 +-
 testdata/golden/meta/schizo_270.mp4.meta.json          | 2 +-
 testdata/golden/meta/schizo_90.mp4.meta.json           | 2 +-
 10 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/ffmpeg/ffmpeg.go b/ffmpeg/ffmpeg.go
index 6249b58..4b44c4b 100644
--- a/ffmpeg/ffmpeg.go
+++ b/ffmpeg/ffmpeg.go
@@ -97,6 +97,9 @@ func (av *AVContext) SelectFrame(n int) (err error) {
 		nn = av.thumbContext.n - 1
 	}
 	av.selectedIndex = nn
+	if err = av.ProcessFrames(-1); err != nil {
+		return
+	}
 	return nil
 }
 
diff --git a/ffmpeg/ffmpeg_test.go b/ffmpeg/ffmpeg_test.go
index 45b0571..7e96922 100644
--- a/ffmpeg/ffmpeg_test.go
+++ b/ffmpeg/ffmpeg_test.go
@@ -72,9 +72,6 @@ func TestAVContext(t *testing.T) {
 					if frame > -1 {
 						require.NoError(t, av.SelectFrame(frame))
 					}
-					if frame != 9999 {
-						require.NoError(t, av.ProcessFrames(-1))
-					}
 				}
 				meta := av.Metadata()
 				metaBuf, err := json.Marshal(meta)
diff --git a/testdata/golden/meta/alpha-webm.webm.meta.json b/testdata/golden/meta/alpha-webm.webm.meta.json
index 466a08c..357c63c 100644
--- a/testdata/golden/meta/alpha-webm.webm.meta.json
+++ b/testdata/golden/meta/alpha-webm.webm.meta.json
@@ -1 +1 @@
-{"orientation":1,"duration":12040,"width":720,"height":576,"fps":25,"selected_frame":45,"has_video":true,"has_audio":false}
\ No newline at end of file
+{"orientation":1,"duration":12040,"width":720,"height":576,"has_video":true,"has_audio":false}
\ No newline at end of file
diff --git a/testdata/golden/meta/everybody-betray-me.mkv.meta.json b/testdata/golden/meta/everybody-betray-me.mkv.meta.json
index ddbd058..07cc731 100644
--- a/testdata/golden/meta/everybody-betray-me.mkv.meta.json
+++ b/testdata/golden/meta/everybody-betray-me.mkv.meta.json
@@ -1 +1 @@
-{"orientation":1,"duration":7407,"width":640,"height":480,"fps":30,"selected_frame":43,"has_video":true,"has_audio":true}
\ No newline at end of file
+{"orientation":1,"duration":7407,"width":640,"height":480,"has_video":true,"has_audio":true}
\ No newline at end of file
diff --git a/testdata/golden/meta/macabre.mp4.meta.json b/testdata/golden/meta/macabre.mp4.meta.json
index 0db3f5b..e247d01 100644
--- a/testdata/golden/meta/macabre.mp4.meta.json
+++ b/testdata/golden/meta/macabre.mp4.meta.json
@@ -1 +1 @@
-{"orientation":1,"duration":3925,"width":492,"height":360,"fps":30,"selected_frame":11,"has_video":true,"has_audio":true}
\ No newline at end of file
+{"orientation":1,"duration":3925,"width":492,"height":360,"has_video":true,"has_audio":true}
\ No newline at end of file
diff --git a/testdata/golden/meta/schizo.flv.meta.json b/testdata/golden/meta/schizo.flv.meta.json
index 7414915..62d3cfb 100644
--- a/testdata/golden/meta/schizo.flv.meta.json
+++ b/testdata/golden/meta/schizo.flv.meta.json
@@ -1 +1 @@
-{"orientation":1,"duration":2560,"width":480,"height":360,"fps":30,"selected_frame":28,"has_video":true,"has_audio":true}
\ No newline at end of file
+{"orientation":1,"duration":2560,"width":480,"height":360,"has_video":true,"has_audio":true}
\ No newline at end of file
diff --git a/testdata/golden/meta/schizo_0.mp4.meta.json b/testdata/golden/meta/schizo_0.mp4.meta.json
index 1f01e08..39438cd 100644
--- a/testdata/golden/meta/schizo_0.mp4.meta.json
+++ b/testdata/golden/meta/schizo_0.mp4.meta.json
@@ -1 +1 @@
-{"orientation":1,"duration":2544,"width":480,"height":360,"fps":30,"selected_frame":11,"has_video":true,"has_audio":true}
\ No newline at end of file
+{"orientation":1,"duration":2544,"width":480,"height":360,"has_video":true,"has_audio":true}
\ No newline at end of file
diff --git a/testdata/golden/meta/schizo_180.mp4.meta.json b/testdata/golden/meta/schizo_180.mp4.meta.json
index d92073e..66e5afd 100644
--- a/testdata/golden/meta/schizo_180.mp4.meta.json
+++ b/testdata/golden/meta/schizo_180.mp4.meta.json
@@ -1 +1 @@
-{"orientation":3,"duration":2544,"width":480,"height":360,"fps":30,"selected_frame":8,"has_video":true,"has_audio":true}
\ No newline at end of file
+{"orientation":3,"duration":2544,"width":480,"height":360,"has_video":true,"has_audio":true}
\ No newline at end of file
diff --git a/testdata/golden/meta/schizo_270.mp4.meta.json b/testdata/golden/meta/schizo_270.mp4.meta.json
index fd715a3..14ea544 100644
--- a/testdata/golden/meta/schizo_270.mp4.meta.json
+++ b/testdata/golden/meta/schizo_270.mp4.meta.json
@@ -1 +1 @@
-{"orientation":6,"duration":2544,"width":360,"height":480,"fps":30,"selected_frame":11,"has_video":true,"has_audio":true}
\ No newline at end of file
+{"orientation":6,"duration":2544,"width":360,"height":480,"has_video":true,"has_audio":true}
\ No newline at end of file
diff --git a/testdata/golden/meta/schizo_90.mp4.meta.json b/testdata/golden/meta/schizo_90.mp4.meta.json
index 4f357a2..7216654 100644
--- a/testdata/golden/meta/schizo_90.mp4.meta.json
+++ b/testdata/golden/meta/schizo_90.mp4.meta.json
@@ -1 +1 @@
-{"orientation":8,"duration":2544,"width":360,"height":480,"fps":30,"selected_frame":9,"has_video":true,"has_audio":true}
\ No newline at end of file
+{"orientation":8,"duration":2544,"width":360,"height":480,"has_video":true,"has_audio":true}
\ No newline at end of file