CEF/grumble
1
0
Fork 0
forked from External/grumble
Code Pull requests Activity

pkg/blobstore: modernize the blobstore package.

Browse source
This commit is contained in:
Mikkel Krautz 2013-02-04 23:36:45 +01:00
parent 8effbbc6b3
commit 3dc3b25f57
10 changed files with 244 additions and 409 deletions
Download patch file Download diff file Expand all files Collapse all files

148
pkg/blobstore/blobstore_test.go
View file

@ -10,91 +10,9 @@ import (
"encoding/hex"
"io/ioutil"
"os"
"path/filepath"
"testing"
)
func TestMakeAllCreateAll(t *testing.T) {
dir, err := ioutil.TempDir("", "blobstore")
if err != nil {
t.Error(err)
return
}
defer os.RemoveAll(dir)
bs, err := NewBlobStore(dir)
if err != nil {
t.Error(err)
return
}
defer bs.Close()
// Check whether the blobstore created all the directories...
for i := 0; i < 256; i++ {
for j := 0; j < 256; j++ {
dirname := filepath.Join(dir, hex.EncodeToString([]byte{byte(i)}), hex.EncodeToString([]byte{byte(j)}))
fi, err := os.Stat(dirname)
if err != nil {
t.Fatal(err)
}
if !fi.IsDir() {
t.Errorf("Not a directory")
}
}
}
}
func TestAllInvalidFiles(t *testing.T) {
dir, err := ioutil.TempDir("", "blobstore")
if err != nil {
t.Error(err)
return
}
defer os.RemoveAll(dir)
err = ioutil.WriteFile(filepath.Join(dir, "00"), []byte{0x0f, 0x00}, 0600)
if err != nil {
t.Error(err)
}
_, err = NewBlobStore(dir)
if err == ErrBadFile {
// Success
} else if err != nil {
t.Error(err)
} else {
t.Error("NewBlobStore returned without error")
}
}
func TestAllInvalidFilesLevel2(t *testing.T) {
dir, err := ioutil.TempDir("", "blobstore")
if err != nil {
t.Error(err)
return
}
defer os.RemoveAll(dir)
err = os.Mkdir(filepath.Join(dir, "00"), 0700)
if err != nil {
t.Error(err)
}
err = ioutil.WriteFile(filepath.Join(dir, "00", "00"), []byte{0x0f, 0x00}, 0600)
if err != nil {
t.Error(err)
}
_, err = NewBlobStore(dir)
if err == ErrBadFile {
// Success
} else if err != nil {
t.Error(err)
} else {
t.Error("NewBlobStore returned without error")
}
}
func TestStoreRetrieve(t *testing.T) {
dir, err := ioutil.TempDir("", "blobstore")
if err != nil {
@ -103,12 +21,7 @@ func TestStoreRetrieve(t *testing.T) {
}
defer os.RemoveAll(dir)
bs, err := NewBlobStore(dir)
if err != nil {
t.Error(err)
return
}
defer bs.Close()
bs := OpenBlobStore(dir)
data := []byte{0xde, 0xad, 0xca, 0xfe, 0xba, 0xbe, 0xbe, 0xef}
@ -136,12 +49,7 @@ func TestReadNonExistantKey(t *testing.T) {
}
defer os.RemoveAll(dir)
bs, err := NewBlobStore(dir)
if err != nil {
t.Error(err)
return
}
defer bs.Close()
bs := OpenBlobStore(dir)
h := sha1.New()
h.Write([]byte{0x42})
@ -160,12 +68,7 @@ func TestReadInvalidKeyLength(t *testing.T) {
}
defer os.RemoveAll(dir)
bs, err := NewBlobStore(dir)
if err != nil {
t.Error(err)
return
}
defer bs.Close()
bs := OpenBlobStore(dir)
key := ""
for i := 0; i < 5; i++ {
@ -173,13 +76,13 @@ func TestReadInvalidKeyLength(t *testing.T) {
}
_, err = bs.Get(key)
if err != ErrInvalidKey {
if err != ErrBadKey {
t.Error("Expected invalid key for %v, got %v", key, err)
return
}
}
func TestReadInvalidKeyNonHex(t *testing.T) {
func TestReadBadKeyNonHex(t *testing.T) {
dir, err := ioutil.TempDir("", "blobstore")
if err != nil {
t.Error(err)
@ -187,12 +90,7 @@ func TestReadInvalidKeyNonHex(t *testing.T) {
}
defer os.RemoveAll(dir)
bs, err := NewBlobStore(dir)
if err != nil {
t.Error(err)
return
}
defer bs.Close()
bs := OpenBlobStore(dir)
key := ""
for i := 0; i < 40; i++ {
@ -200,38 +98,8 @@ func TestReadInvalidKeyNonHex(t *testing.T) {
}
_, err = bs.Get(key)
if err != ErrInvalidKey {
t.Errorf("Expected invalid key for %v, got %v", key, err)
if err != ErrBadKey {
t.Errorf("Expected bad key for %v, got %v", key, err)
return
}
}
func TestDefaultBlobStore(t *testing.T) {
dir, err := ioutil.TempDir("", "blobstore")
if err != nil {
t.Error(err)
return
}
defer os.RemoveAll(dir)
err = Open(dir)
if err != nil {
t.Error(err)
}
data := []byte{0xf, 0x0, 0x0, 0xb, 0xa, 0xf}
key, err := Put(data)
if err != nil {
t.Error(err)
}
fetchedData, err := Get(key)
if err != nil {
t.Error(err)
}
if !bytes.Equal(fetchedData, data) {
t.Errorf("stored data and retrieved data does not match: %v vs. %v", fetchedData, data)
}
}