CEF/ergo
1
0
Fork 0
forked from External/ergo
Code Pull requests Activity

fix #2135

Browse source 
Handling of reserved nicknames is special-cased due to #1594, but we want to send
ERR_NICKNAMEINUSE if the nickname is actually in use, since that doesn't pose any
client compatibility problems.
This commit is contained in:
Shivaram Lingamneni 2024-03-11 01:32:39 -04:00
parent 681e8b1292
commit 837f6ac1a2
2 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
irc/nickname.go
View file

@ -43,6 +43,8 @@ func performNickChange(server *Server, client *Client, target *Client, session *
}
} else if err == errNicknameReserved {
if !isSanick {
// see #1594 for context: ERR_NICKNAMEINUSE can confuse clients if the nickname is not
// literally in use:
if !client.registered {
rb.Add(nil, server.name, ERR_NICKNAMEINUSE, details.nick, utils.SafeErrorParam(nickname), client.t("Nickname is reserved by a different account"))
}